Database structure for the modules and submodules are
name: Custom Breadcrumb
fields: bid, name, titles, path, visibility_php, node_type, language
name: Custom Breadcrumb Path
fields: bid, name, titles, path, visibility_php, specifc_path, language
...
name: Custom Breadcrumb X
fields: bid, name, titles, path, visibility_php, X, language

Every table just has 1 field different.

Things I would sugguest
#1 table custom_breadcrumb be renamed custom_breadcrumb_node
#2 table structure like so:
name: Custom Breadcrumb
fields: bid, name, titles, path, visibility_php,language
name: Custom Breadcrumb Node
fields: cbid, node_type
name: Custom Breadcrumb Path
fields: cbid, specific_path
....
name: Custom Breadcrumb X
fields: cbid, X

I also though we should add an extra field to custom breadcrumb table and eliminate all the other tables, however I think this would break on Custom Breadcrumb Taxonomy and Custom Breadcrumb Vocabulary, as their "extra" field is a number.

Thoughts?

Comments

MGN’s picture

A couple of things to think about here.

First, I would like to have a stable release of 6.x-2.0 soon, and completely reworking the database structure should wait - possibly for custom breadcrumbs 3.

As you consider changes to the database, don't forget to write the necessary updates so people can migrate from (at least) 6.x-2.x-dev (current structure) and 6.x-1.5.

I do agree that changes to the database structure should be considered and welcome the contribution!