Remove argument type 'struct' in favor of 'array'

In the past I have always wanted the individual resources to match their underlying API calls (IE node_load() requires an object, so node.load should require one too.) However what has ended up happening is that in many of the services, we check to see if the argument is the correct format, and if not we cast it to whatever we want anyways. Having a constant rule that everything is an array would make it simpler on the end users and provide a more consistent interface, so +1 to this.

Now the question is, what needs to be done to support this? Is there any real change required other than modifying the Service definitions?

Well the browser is gone in 6.3, so that is not a problem anymore (well, not for us anyways.) I'm not sure what would have to be done in XMLRPC server. In theory nothing since all it really does is pass everything down to the core XMLRPC calls.

The xmlrpc server recieves all drupal objects as an array, so heyrocker's comment is correct nothing needs to be done it will continue to work.

Moving to current version and setting as postponed for consideration in 7.4

If this needs to be 'fixed' in one or another then it makes sense to get it into 7.3, reclassifying as a task rather thana feature request.

Here is patch that replaces 'struct' to 'array'.

All tests pass and looking over the code, im happy with everything here. Ill leave to needs review so others can post and if there are no objections Ill commit this before End of week.

Going through the code and I notice that in _user_resource_update we are still casting to an object is this by design?

It seems strange as we then cast back to an array here

foreach ((array)$account as $key => $value) {

So we process the incoming data as both an array and an object, as I say I might be missing something.

In _node_resource_create again we have something strange going on

As we cast to an object and then cast to an array, I am assuming the object cast can be replaced with the array cast. _node_resource_update has a similar issue. As does _comment_resource_create and _comment_resource_update.

This illustrates what I'm talking about to some extent http://drupalbin.com/18167 - maybe a little outside of scope but tidying this up would be nice.

reroll including comment above

Need to remove the casts and tidy up patch

I have rerolled patch. Fixed tests and trailing whitespaces based on #12.

upload proper patch

After quick glance it looks good to me.

Removes some unneeded casts

Lets try this instead

I am happy with patch #18.

Oops. Please commit attached patch as well. As now parameters in node index method get NULL default value instead of empty array.

Here is patch for 6.x-3.x.