On forms with the language selection turned on are vertical tabs overlapping the form. Vertical tabs also get pushed right so the alignment is all wrong. The problem is locale.css have it's own form styling and are adding float and margin setting that break our layout.

.form-item-language, .form-item-translation, .form-item-group {
float:left;
margin:0.1em;
padding-right:0.8em;
width:15em;
}

I do not think .form-item in the locale module is "special" in any way and should try to remove as many of these module specific styles as possible then it only causes us grief. Tested on FF 3.6 with Garland RTL. We need more to test this.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

steinmb’s picture

FileSize
588 bytes

Let's try this and see what we can break.

steinmb’s picture

Attaching a screenshot of the problem, forgot that :) I have done some more testing of the patch LTR and RTL:
FF 3.6.x
Opera 10.6.x
Safari 5.x
Chrome 7.x
Seems to be working OK. Tested with overlay turned off only in Garland.

droplet’s picture

FileSize
18.19 KB

@steinmb
how to reproduce this error

steinmb’s picture

Hmm. Do you use the overlay? Latest D7 dev.? What browser is this?
Check to see if your browser load the same settings from locale.css –file that I get. I did not do anything special to provoke this bug, only upgraded from D6 and there it was.

brucepearson’s picture

I was getting the same problem. The patch in #1 fixed it for me.

klonos’s picture

Same here: nothing special in order to reproduce, not using the overlay, patch in #1 fixed things.

This is really trivial, I know, but we should try to push it to D7 final since it sort of blocks people from selecting a form element (don't know if this counts as usability though). I know that the only way to get attention is to mark it 'critical', but the truth is it is far from even 'major'. I mean, come on, it's just a 3-liner and seems like a no-brainer too.

Sivaji_Ganesh_Jojodae’s picture

I could not reproduce this bug. It looks good for me, see the attachments.

klonos’s picture

You are using overlay though. Right? If so. could you please disable it and try again?

If overlay is disabled, then are you on Windows or what (seems like Mac to me)? x64 or x86?

droplet’s picture

seems like sivaji & me miss some steps. which on my side do not load the locale.css. so everything is fine

steinmb’s picture

Hmm why does not locale.css get loaded? The module enabled? Could this be related? #914194: locale.css loaded and applied on other pages and elements

klonos’s picture

Just went through a new D7 dev setup on postresql and only took the minimum steps in order to reproduce this:

- enabled admin_menu & disabled the core toolbar
- enabled locale module
- added another language and set it as default
- enabled garland and set it as default theme
- set garland theme as admin theme
- disabled overlay from user account settings
- enabled multilingual support in the basic page content type

So far the language selection drop-down displays fine on node creation from. Stay tuned as I enable more modules and go through various other settings till I reproduce it...

droplet’s picture

#1019608: language selector overlaps with vertical tabs in the node/edit

Steps to reproduce:
1) create content type with Publishing options -> Multilingual support -> Enabled, with translation (or just Enabled).
2) node/add this content type and see attached picture (edit1.png).

Note: When you choose "enabled, with translation", there is a "translation settings" fieldset (after you add a translation). This additional fieldset restores page layout (see edit2.png).
OnkelTem’s picture

It's not particularly the Garland's issue - this happens also when Bartik or Seven is active: http://drupal.org/node/1025510

steinmb’s picture

@OnkelTem thanx. We better change the title of this issue then, any suggestion to a descriptive title? I do not get why not more users trigger this bug though.

OnkelTem’s picture

@steinmb

> We better change the title of this issue then, any suggestion to a descriptive title?

I though about this too and incline to using 'locale.css' in the title, just like I did in my issue: http://drupal.org/node/1025510

> I do not get why not more users trigger this bug though.

My guess - its too easy to fix for someone to be bothered in reporting, prefering to simpy add something like:

.form-item-language,
.form-item-translation,
.form-item-group {
  float: none;
  width: auto;
}
OnkelTem’s picture

> I do not get why not more users trigger this bug though.

I probably misread this your sentence. The triggering (inclusion) happens in locale_block_view() function, which is Language switching block, so when you have it enabled, locale.css is loaded.

Anyways, I see no reason to live with code any longer - why not to either remove the declaration, or make it more specific?
Why it takes so much time to do the fix (problem had been reported in October!)?

steinmb’s picture

Title: Garland, vertical tab overlaps language selection form » locale.css cases vertical tab. to overlap teh language selection form

Thanks for the clarification on why/where locale.css get included. Well I created a patch back in October simply removing the float (#1), but non with commit access have picked up this issue.

droplet’s picture

Status: Active » Needs review
FileSize
516 bytes

locale.css also load in locale admin page, the css rules is used in there. so we can't use #1 patch, instead adding specified rules.

if it can make l & theme_links function take care of lang session detection, then we can remove locale.css loading in locale block. (it's anther issues, maybe a bug.)

hswong3i’s picture

Confirm that patch from #18 works with drupal-7.0.

klonos’s picture

Title: locale.css cases vertical tab. to overlap teh language selection form » locale.css causes vertical tabs to overlap the language selection drop-down menu in node edit forms

...correcting a few typos + adding more details in title.

Also adding a link to the screenshot from #1025510: locale.css breakes node editing forms that shows the issue in other theme besides Garland.

Finally, I too confirm #18 works fine. Thanx ;)

klonos’s picture

...still an annoyance in latest D7 dev. Who does this need to be reviewed from? Does the fact that that the patch in #18 solve the issue for at least 2 people here count as RBTC?

droplet’s picture

Status: Needs review » Reviewed & tested by the community

@klonos

yes, it's a simple fix only and 2 people confirmed that works.

klonos’s picture

Issue tags: +Quick fix

I kinda already knew that ;)

...It's just that I got a bit 'intimidated' by the description of the RTBC status where it states:

The patch has received a *thorough review* and test by one or more *experienced developers*, and they have deemed it as ready to be committed to the project.

...so, I did not want to go ahead and set it to such and risk the 'wrath' of anyone ;)

PS: I believe we also tag issues with no-brainer fixes as 'Quick fix' as well, so tagging it as such.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

klonos’s picture

Thanx Dries! One less patch to keep track of ;)

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.