Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
On forms with the language selection turned on are vertical tabs overlapping the form. Vertical tabs also get pushed right so the alignment is all wrong. The problem is locale.css have it's own form styling and are adding float and margin setting that break our layout.
.form-item-language, .form-item-translation, .form-item-group {
float:left;
margin:0.1em;
padding-right:0.8em;
width:15em;
}
I do not think .form-item in the locale module is "special" in any way and should try to remove as many of these module specific styles as possible then it only causes us grief. Tested on FF 3.6 with Garland RTL. We need more to test this.
Comment | File | Size | Author |
---|---|---|---|
#18 | locale.patch | 516 bytes | droplet |
#7 | language-select-chrome8.png | 60.67 KB | Sivaji_Ganesh_Jojodae |
#7 | language-select-firefox4.png | 48.57 KB | Sivaji_Ganesh_Jojodae |
#3 | g.png | 18.19 KB | droplet |
#2 | Screen shot 2010-10-26 at 10.49.30.png | 55.13 KB | steinmb |
Comments
Comment #1
steinmb CreditAttribution: steinmb commentedLet's try this and see what we can break.
Comment #2
steinmb CreditAttribution: steinmb commentedAttaching a screenshot of the problem, forgot that :) I have done some more testing of the patch LTR and RTL:
FF 3.6.x
Opera 10.6.x
Safari 5.x
Chrome 7.x
Seems to be working OK. Tested with overlay turned off only in Garland.
Comment #3
droplet CreditAttribution: droplet commented@steinmb
how to reproduce this error
Comment #4
steinmb CreditAttribution: steinmb commentedHmm. Do you use the overlay? Latest D7 dev.? What browser is this?
Check to see if your browser load the same settings from locale.css –file that I get. I did not do anything special to provoke this bug, only upgraded from D6 and there it was.
Comment #5
brucepearson CreditAttribution: brucepearson commentedI was getting the same problem. The patch in #1 fixed it for me.
Comment #6
klonosSame here: nothing special in order to reproduce, not using the overlay, patch in #1 fixed things.
This is really trivial, I know, but we should try to push it to D7 final since it sort of blocks people from selecting a form element (don't know if this counts as usability though). I know that the only way to get attention is to mark it 'critical', but the truth is it is far from even 'major'. I mean, come on, it's just a 3-liner and seems like a no-brainer too.
Comment #7
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedI could not reproduce this bug. It looks good for me, see the attachments.
Comment #8
klonosYou are using overlay though. Right? If so. could you please disable it and try again?
If overlay is disabled, then are you on Windows or what (seems like Mac to me)? x64 or x86?
Comment #9
droplet CreditAttribution: droplet commentedseems like sivaji & me miss some steps. which on my side do not load the locale.css. so everything is fine
Comment #10
steinmb CreditAttribution: steinmb commentedHmm why does not locale.css get loaded? The module enabled? Could this be related? #914194: locale.css loaded and applied on other pages and elements
Comment #11
klonosJust went through a new D7 dev setup on postresql and only took the minimum steps in order to reproduce this:
- enabled admin_menu & disabled the core toolbar
- enabled locale module
- added another language and set it as default
- enabled garland and set it as default theme
- set garland theme as admin theme
- disabled overlay from user account settings
- enabled multilingual support in the basic page content type
So far the language selection drop-down displays fine on node creation from. Stay tuned as I enable more modules and go through various other settings till I reproduce it...
Comment #12
droplet CreditAttribution: droplet commented#1019608: language selector overlaps with vertical tabs in the node/edit
Comment #13
OnkelTem CreditAttribution: OnkelTem commentedIt's not particularly the Garland's issue - this happens also when Bartik or Seven is active: http://drupal.org/node/1025510
Comment #14
steinmb CreditAttribution: steinmb commented@OnkelTem thanx. We better change the title of this issue then, any suggestion to a descriptive title? I do not get why not more users trigger this bug though.
Comment #15
OnkelTem CreditAttribution: OnkelTem commented@steinmb
> We better change the title of this issue then, any suggestion to a descriptive title?
I though about this too and incline to using 'locale.css' in the title, just like I did in my issue: http://drupal.org/node/1025510
> I do not get why not more users trigger this bug though.
My guess - its too easy to fix for someone to be bothered in reporting, prefering to simpy add something like:
Comment #16
OnkelTem CreditAttribution: OnkelTem commented> I do not get why not more users trigger this bug though.
I probably misread this your sentence. The triggering (inclusion) happens in locale_block_view() function, which is Language switching block, so when you have it enabled, locale.css is loaded.
Anyways, I see no reason to live with code any longer - why not to either remove the declaration, or make it more specific?
Why it takes so much time to do the fix (problem had been reported in October!)?
Comment #17
steinmb CreditAttribution: steinmb commentedThanks for the clarification on why/where locale.css get included. Well I created a patch back in October simply removing the float (#1), but non with commit access have picked up this issue.
Comment #18
droplet CreditAttribution: droplet commentedlocale.css also load in locale admin page, the css rules is used in there. so we can't use #1 patch, instead adding specified rules.
if it can make l & theme_links function take care of lang session detection, then we can remove locale.css loading in locale block. (it's anther issues, maybe a bug.)
Comment #19
hswong3i CreditAttribution: hswong3i commentedConfirm that patch from #18 works with drupal-7.0.
Comment #20
klonos...correcting a few typos + adding more details in title.
Also adding a link to the screenshot from #1025510: locale.css breakes node editing forms that shows the issue in other theme besides Garland.
Finally, I too confirm #18 works fine. Thanx ;)
Comment #21
klonos...still an annoyance in latest D7 dev. Who does this need to be reviewed from? Does the fact that that the patch in #18 solve the issue for at least 2 people here count as RBTC?
Comment #22
droplet CreditAttribution: droplet commented@klonos
yes, it's a simple fix only and 2 people confirmed that works.
Comment #23
klonosI kinda already knew that ;)
...It's just that I got a bit 'intimidated' by the description of the RTBC status where it states:
...so, I did not want to go ahead and set it to such and risk the 'wrath' of anyone ;)
PS: I believe we also tag issues with no-brainer fixes as 'Quick fix' as well, so tagging it as such.
Comment #24
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.
Comment #25
klonosThanx Dries! One less patch to keep track of ;)