Poll Module throws PDOException when creating poll content

I'm able to reproduce this bug. It looks like you added 'No' to 'Vote count' field and validation doesn't work for this field in some reason.

There is bug in function poll_insert in poll.module. We are using following code (line 537):

  foreach ($node->choice as $choice) {
    if ($choice['chtext'] != '') {
      db_insert('poll_choice')
        ->fields(array(
          'nid' => $node->nid,
          'chtext' => $choice['chtext'],
          'chvotes' => $choice['chvotes'],
          'weight' => $choice['weight'],
        ))
        ->execute();
    }
  }

To fix bug we should use updated code:

  foreach ($node->choice as $choice) {
    if ($choice['chtext'] != '') {
      db_insert('poll_choice')
        ->fields(array(
          'nid' => $node->nid,
          'chtext' => $choice['chtext'],
          'chvotes' => (int) $choice['chvotes'],
          'weight' => $choice['weight'],
        ))
        ->execute();
    }
  }

The solution here is to fix the validation, not the database insert.

Attached patch cleans up this mess and applies cleanly to D7 and D8. I promise to follow up with tests in #295993: TestingParty08: Poll form validation :)

Re-rolled to take http://drupal.org/node/1274212#comment-4973492 into account.

The string changes were not accepted for D7, so here's another patch that keeps the string and reuses one from number.module.

Again, I'd recommend to postpone this until #1274212: Incorrect order of choices in Poll module. is fixed.

Can't we just use element_validate_integer_positive as an element validator?

This really also needs tests.

@marcingy: good idea, but element_validate_integer instead of element_validate_integer_positive because the vote count can be 0.

I asked @chx in IRC to validate the test-only patch, and the only 'complaint' was that we don't need to logout the admin user because login does it for us.

So, new patches for review (It's sad that I can't stop the testbot from reviewing the previous ones..), and if everythings checks out, I'm going to RTBC based on the idea from #9 and the validated tests :)

RTBC it is then.

Thanks. Committed/pushed to 8.x. Moving to 7.x for backport.

7.x patch.

Committed and pushed to 7.x. Thanks for the fix, and the test!

Shouldn't the code also include #required => true?

Otherwise saving a poll node form with no values in the "count" fields gives "PDOException: SQLSTATE[HY000]: General error: 1366 Incorrect integer value: '' for column 'chvotes'".

Ok! Right!
So just added '#required => True' in line 412

$form['chvotes'] = array(
    '#type' => 'textfield',
    '#title' => $value !== '' ? t('Vote count for choice @label', array('@label' => $value)) : t('Vote count for new choice'),
    '#title_display' => 'invisible',
    '#default_value' => $votes,
    '#size' => 5,
    '#maxlength' => 7,
    '#parents' => array('choice', $key, 'chvotes'),
    '#access' => user_access('administer nodes'),
    '#required' => True,
    '#element_validate' => array('element_validate_integer'),
  );

We still need to D7 patch to review so changing the status.