See attached patch. Went with basic defaults for field types. I have not tested extensively in regular use so please post feedback!

CommentFileSizeAuthor
#4 advpoll.install.patch.txt1.3 KBjaydub
advpoll.patch1.36 KBjaydub

Comments

jaydub’s picture

jaydub commented

a quick shows that some of the queries don't play well with the PostgreSQL boolean type so the fields I set as boolean should perhaps instead be smallint.

ChrisKennedy’s picture

ChrisKennedy commented
Category: support » bug
Status: Needs review » Needs work

Thanks for the patch - I don't have postgresql unfortunately but if you can do a little more testing and update the patch I will commit it to 4.7 and port it to 5.0 also.

ChrisKennedy’s picture

ChrisKennedy commented

I went ahead and committed this to HEAD in the hopes that someone will test it; booleans were changed to smallints. Possibly buggy PostgreSQL support is better than no support after all. http://drupal.org/cvs?commit=46524

jaydub’s picture

jaydub commented
Status: Needs work » Needs review
StatusFileSize
new advpoll.install.patch.txt1.3 KB

hey there sorry I haven't been able to get back to you on PostgreSQL support. I have attached an updated patch to deal with 2 issues in the original .install pgsql support. First is setting default value of 0 for the quorum field in the advpoll table. Second is creation of PostgreSQL sequence table for storing current id of votingapi_cache.

ChrisKennedy’s picture

ChrisKennedy commented
Version: 4.7.x-1.x-dev » 5.x-1.x-dev
Status: Needs review » Fixed

Okay I committed the quorum change, but the votingapi_cache sequence needs to be in the votingapi module, not advpoll.

http://drupal.org/cvs?commit=59180

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)