Closed (fixed)
Project:
Bookings API
Version:
6.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Sep 2010 at 19:40 UTC
Updated:
29 Oct 2010 at 14:30 UTC
Jump to comment: Most recent
Comments
Comment #1
Anonymous (not verified) commentedThanks. I somehow missed this...
Comment #2
Anonymous (not verified) commentedCommitted.
Actually the problem is that $date is valid outside of its scope. And as its a reference ... Thanks for noticing and fixing!
Comment #3
developer-x commentedCool - I come from the Java world - a redeclaration like this causes a compiler error. PHP seems to quietly ignore the redeclaration - nasty.....
Comment #4
Anonymous (not verified) commentedIts not a real redeclaration - you don't need to declare variables in PHP before you use them (and yes, I prefer Java too ;) )
Comment #5
developer-x commentedI definitely didn't say I preferred Java ;-)
Actually, for web apps, I much perfer PHP - there is too much subtlety and far too much fussiness with Java for what a web app requires. Passing simple arrays/hashtables around the PHP way is way more productive than the whole OO/ORM/Spring/WebFlow/Struts/Tiles/JSP (add your technology component here). And you can't beat Drupal infrastructure and the community for delivering easy to deploy and integrate User functionality.
If I'm in the business of producing a transaction heavy airline reservation or banking system with a well established and non-flexible datamodel - give me the whole Java/SOA thing - but ask me to build a webapp - I'll take Drupal, thank you.
Anyway - just got that off my chest ;-)
Glad this worked out. BTW, great job with the bookingsapi - very thorough - and well done with all the unit testing.