Periods are missing in some code comments, such as Settings callback for foo filter. Also perhaps some of the language could be clearer. Will roll a patch when i think i understand it well enough!

Also, what's the etiquette for a code comment not attached to anything, such as the /** */ block introducing the first example filter? Allowed, discouraged, only in example modules? :-)

CommentFileSizeAuthor
#3 examples-filter-cleanup.patch3.07 KBilo

Comments

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

I'm actually not the world's best coding style person. I know you're already familiar with http://drupal.org/coding-standards. Feel free to improve anything you see with patches. If you're trying to follow the coding standards it will be well-received.

-Randy

ilo’s picture

ilo commented
Category: bug » task

Lets postpone it for a later review as a task, it is not a bug.

ilo’s picture

ilo commented
Status: Active » Needs review
StatusFileSize
new examples-filter-cleanup.patch3.07 KB

Don't know if it is enough, but thats an start. No periods missing, coder does complain, and IMHO it is quite easy to understand.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Fixed

Committed to CVS HEAD: http://drupal.org/cvs?commit=427666

Thanks, ilo, @Benjamin.

Status: Fixed » Closed (fixed)
Issue tags: -dgd7

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +dgd7

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.