Implement code to allow the handling of exports node deffinitions to a feature. This functionality requires strongarm, but doesn't break anything if strongarm doesn't exist.

Comments

gordon’s picture

Status: Active » Needs review
StatusFileSize
new700 bytes

attach patch

gordon’s picture

StatusFileSize
new696 bytes

The hook changed on me. Fixed.

Status: Needs review » Needs work

The last submitted patch, 897310.patch, failed testing.

dave reid’s picture

Version: 6.x-1.4 » 7.x-1.x-dev

New features are applied to 7.x-1.x only and then backported to 6.x-2.x. The 6.x-1.x branch is closed to feature requests.

hefox’s picture

(#728004: Allow abitrary modules to alter the pipeline is the issue about the hook; subscribe)

cyberwolf’s picture

Subscribing.

bc’s picture

subscribing

kehan’s picture

subscribing

dave reid’s picture

This also doesn't account for any multi-lingual variables.

joachim’s picture

Issue summary: View changes

Ah yes, I see in pathauto_pattern_load_by_entity():

    if ($language != LANGUAGE_NONE) {
      $variables[] = "pathauto_{$entity}_{$bundle}_{$language}_pattern";
    }
    if ($bundle) {
      $variables[] = "pathauto_{$entity}_{$bundle}_pattern";
    }
    $variables[] = "pathauto_{$entity}_pattern";

So this patch would need to consider pathauto_node_{$bundle}_pattern for the current node types being exported, and also pathauto_node_{$bundle}_{$language}_pattern, presumably for all languages enabled on the site, or more likely all the variables of that form that are defined.

dave reid’s picture

dave reid’s picture

Status: Needs work » Needs review
StatusFileSize
new1.02 KB

This should work for node types and taxonomy vocabularies.

dave reid’s picture

  • Dave Reid committed 0633e72 on 7.x-1.x
    Issue #897310 by gordon, Dave Reid: Added features integration for...
dave reid’s picture

Status: Needs review » Fixed

Committed #12 to 7.x-1.x.

joelpittet’s picture

Seems this tries to force pathauto into all my existing features... is this intended?

dave reid’s picture

I don't know how Features handles this hook with existing features. But I know this is how we should have supported exporting it from the start. You can always change it and export the settings to another feature, but this matches the behavior of other content-type controlled variables.

joelpittet’s picture

Seems to be producing a bunch of these exclude groupings in different node related features as I ignore the suggestions:

features_exclude[variable][pathauto_node_product_display_en-US_pattern] = pathauto_node_product_display_en-US_pattern
features_exclude[variable][pathauto_node_product_display_pattern] = pathauto_node_product_display_pattern
features_exclude[variable][pathauto_node_product_display_und_pattern] = pathauto_node_product_display_und_pattern
features_exclude[variable][pathauto_taxonomy_term_price_list_pattern] = pathauto_taxonomy_term_price_list_pattern
features_exclude[variable][pathauto_taxonomy_term_product_badge_pattern] = pathauto_taxonomy_term_product_badge_pattern
features_exclude[variable][pathauto_taxonomy_term_product_category_pattern] = pathauto_taxonomy_term_product_category_pattern
features_exclude[variable][pathauto_taxonomy_term_product_group_pattern] = pathauto_taxonomy_term_product_group_pattern
features_exclude[variable][pathauto_taxonomy_term_product_size_pattern] = pathauto_taxonomy_term_product_size_pattern
features_exclude[variable][pathauto_taxonomy_term_product_type_pattern] = pathauto_taxonomy_term_product_type_pattern
features_exclude[variable][pathauto_taxonomy_term_recommender_scents_pattern] = pathauto_taxonomy_term_recommender_scents_pattern
features_exclude[variable][pathauto_taxonomy_term_references_pattern] = pathauto_taxonomy_term_references_pattern
features_exclude[variable][pathauto_taxonomy_term_skin_care_routines_pattern] = pathauto_taxonomy_term_skin_care_routines_pattern
features_exclude[variable][pathauto_taxonomy_term_skin_concerns_pattern] = pathauto_taxonomy_term_skin_concerns_pattern
features_exclude[variable][pathauto_taxonomy_term_skin_types_pattern] = pathauto_taxonomy_term_skin_types_pattern
features_exclude[variable][pathauto_taxonomy_term_store_pattern] = pathauto_taxonomy_term_store_pattern
dave reid’s picture

@joelpittet: Does your content type feature also include all the taxonomy vocabularies exported along with it? Or also have excluded all the vocabularies?

joelpittet’s picture

Vocabularies excluded as well.

dave reid’s picture

Hrm, I'm not sure what to tell you or if this is even a problem. That seems to be expected of Features when you opt-out of the auto-exporting/grouping of variables with the content type / vocabularies.

joelpittet’s picture

Thanks will maybe bring it up in the features queue. Thought I'd share a concern after this was committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.