Hi all, thanks in advanced. Just wondering does anyone get this module working at all? The discount can been seen in the /cart page, but it is not applying after or seen anywhere after a complete checkout process. I also have Google Checkout as well, and it is not applying the discounted price too.
Does anyone has any idea? Is there's any tricks?
| Comment | File | Size | Author |
|---|---|---|---|
| #23 | uc_discounts.patch | 5.32 KB | peem83 |
| #5 | uc_discounts.patch | 5.37 KB | peem83 |
| #18 | discounts.patch | 5.39 KB | peem83 |
Comments
Comment #1
ahlofan commentedThis is my setup
Drupal 6.19
Ubercart 2.4
UC Discount Alt 2.x-dev
Comment #2
acb commentedSeeing this exact same problem. Any ideas?
Comment #3
ahlofan commentedEverything must gone through the Checkout pane. So basically, you cannot use the paypal express or google checkout payment.
Comment #4
maverick14 commentedSame issue here. Discounts are only visible in the cart but do not work for the checkout page and thus order in total.
Comment #5
peem83 commentedI wrote few extra line of code to fix this issue. When you apply the attached patch, go to the themes page and clear cache because the patch contain new theme function.
Comment #6
pixelsweatshop commentedHas this been rolled into the dev version now?
Comment #7
yktdan commentedIt is not in the dev version which is currently 1.29.2.20. It is time to play the alpha/beta/rc/release game so that we have a stable version.
Comment #8
whitelancer commentedPatch in #5 seems to work on the first review page, but on the final confirmation/review page the prices are whacky and very wrong for the discount. I'm actually happy turning it off for the last page, so if/when I figure that out I'll let you know (or maybe peem83 knows how?)
Comment #9
whitelancer commentedAh, seems as simple as commenting out the
if ($discount_amount > 0) {line (and its associated functionality)
Comment #10
pyxio commentedSame problem here. Discounts don't show anywhere except the initial cart page. What file do I need to comment out? Thanks. Kevin
Comment #11
jrust commentedFixed in CVS
Comment #12
pyxio commentedHi,
What do you mean by fixed in CVS? Does that mean I should install the latest dev version? Thanks.
Comment #13
jrust commented6.x-2.0 has the fix.
Comment #14
pyxio commentedHi,
I am using 6.x-2.0 and the only page that shows the discount is the actual order page... none of the checkout screens. Any advice? Thanks.
Comment #15
peem83 commented@whitelancer: What do you mean 'confirmation/review page'. For me it works fine on the checkout and review page which is the last step of the order, isn't it ?
Comment #16
pyxio commentedI see the discount only on the initial cart page... not on checkout or review.
Comment #17
pyxio commentedI am using 6.x-2.0 should I be using 6.x-2.0-dev for this to work?
Comment #18
peem83 commentedWith this patch (for 6.x-2.0-dev) the discounts are shown on checkout and review pages - the same patch like in #5, also in this case when you apply the patch, go to the themes page and clear cache.
Comment #19
jrust commentedOn the review page the discounts should show up in the line items. Is this not the case?
Comment #20
pyxio commentedWhen I try to use either patch here I get an error "malformed patch at line *" What am I doing wrong? Thanks.
Comment #21
peem83 commented@jrust: on the checkout and review pages the discount is present as total discount amount
@talengix: try to add a space in front of the error line, that might help
Comment #22
pyxio commentedI am still getting this error:
patching file uc_discounts.module
patch: **** malformed patch at line 167:
patch unexpectedly ends in middle of line
Comment #23
peem83 commented@talengix: I made new patch, try this one.
Comment #24
pyxio commentedThanks peem83. Unfortunately it is still not working for me... I wonder if I'm doing anything wrong but I have successfully patched modules in the past. Here is the error I get:
/var/www/vhosts/mysite.com/httpdocs/sites/all/modules/uc_discounts_alt/uc_discounts$ patch < uc_discounts_2.patch.txt
patching file uc_discounts.module
patch: **** malformed patch at line 164:
patch unexpectedly ends in middle of line
Comment #25
peem83 commented@talengix: This patch works perfect for me, you can simply copy all the lines which '+' in front from the patch and paste it in the end of the uc_discounts.module and of course remove all the '+'.
Comment #26
pyxio commented@peem83, thanks again. I guess I'm just out of luck today. when I try to manually patch it I get syntax errors. I will probably have to wait until you roll this out in the next version... any idea when that might be? Thanks. Kevin
Comment #27
jrust commentedSo this patch shows the discount amount for items with a codeless discount, correct? I'm hesitant to re-theme the whole review table, it's a lot of copying of core ubercart code that would have to be updated every time a new version of ubercart came out. Is there no way of doing this that just modifies the data from the review table in ubercart? I'm leaning towards thinking adding the amount via javascript, if possible, would be better.
Comment #28
peem83 commentedYou can build new module and use hook_checkout_pane_content to override existing content (look into the patch), and in this case you don't need to do any changes in ubercart.
Comment #29
pyxio commented@jrust - This is such an obvious need I suspect it will be built into the next upgrade, at least I would hope so!
@peem83 - thanks for all of your awesome help
Comment #30
jrust commentedComment #31
paloczp commentedHi!
I had the same problem, but finaly solved it.
Comment #32
hanoiiIsn't this a bug report? I am also not seeing the discount on the review page, nor my gateway, which means the discount is lost in the process.
Comment #33
ilyasmdgh commentedAny updates for this. Does any of the above patch work for someone? Thanks
Comment #34
screenage commentedsubscribing
Comment #35
bgladwyn commentedAlso subscribing, seeing the same problem over here.
Comment #36
jrust commentedThanks, patch applied