This is a slightly restructured version of the patch that went into Drupal 6. All in one as the changes touch the same code.

Code by Damien, Christian (c96...) and myself.

I've test failures in the openid tests both with and without this patch on adding openid_identifier' => '@example*résumé;%25', to user 2.

I suppose this could use additional tests as well.

Files: 
CommentFileSizeAuthor
#7 openid-incomplete-verification-assertions-D7-3.patch13.13 KBBerdir
PASSED: [[SimpleTest]]: [MySQL] 23,235 pass(es). View
#5 openid-incomplete-verification-assertions-D7-2.patch13.15 KBBerdir
FAILED: [[SimpleTest]]: [MySQL] 22,982 pass(es), 1 fail(s), and 0 exception(es). View
openid-incomplete-verification-assertions-D7.patch13.03 KBHeine
PASSED: [[SimpleTest]]: [MySQL] 22,949 pass(es). View

Comments

aspilicious’s picture

+ * The next series of updates should start at 8000.
+ */
\ No newline at end of file

could the committer add a newline after these lines.

Damien Tournoud’s picture

Status: Needs review » Needs work

While we are no in beta yet, openid_update_7000() should just be openid_update_6000(), and we can remove the db_table_exists() call.

Gábor Hojtsy’s picture

BTW this is a followup to SA-CORE-2010-002.

Berdir’s picture

Assigned: Unassigned » Berdir

Looks like nobody is working on this yet on the summit, I'll do a re-roll, doesn't look too complicated...

Berdir’s picture

Status: Needs work » Needs review
FileSize
13.15 KB
FAILED: [[SimpleTest]]: [MySQL] 22,982 pass(es), 1 fail(s), and 0 exception(es). View

Just a simple re-roll with the update function renamed and newlines added...

Damien Tournoud’s picture

Status: Needs review » Needs work
+/**
+ * @defgroup openid-updates-6.x-to-7.x OpenID updates from 6.x to 7.x
+ * @{
+ */

^ Those should be in the Drupal 6 extra group.

Berdir’s picture

Status: Needs work » Needs review
FileSize
13.13 KB
PASSED: [[SimpleTest]]: [MySQL] 23,235 pass(es). View

Obviously...

The test fail looks totally unrelated and works for me locally. Maybe the test is unstable....

Dries’s picture

I looked at this patch and it looks RTBC, assuming that the testbot gives us the green light.

+++ modules/openid/openid.install
@@ -84,3 +110,46 @@ function openid_requirements($phase) {
+        'description' => 'The value of openid.response_nonce'

Very minor but we're missing a point in the description. I can fix that prior to committing.

Dries’s picture

Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work
Issue tags: -Security Advisory follow-up

The last submitted patch, openid-incomplete-verification-assertions-D7-3.patch, failed testing.

beeradb’s picture

Status: Needs work » Needs review
Issue tags: +Security Advisory follow-up
beeradb’s picture

Hmm, the last 2 patches have failed for two different reasons within 2 hours. I haven't followed what has gone in today and/or if anything broke the test bot, but I requested a re-test and am crossing my fingers that this passes.

David Strauss’s picture

This may be "critical," but it's not a beta-blocker. People barely notice when OpenID is broken in stable releases.

meba’s picture

$0.02: If I understood correctly, if this doesn't land before beta, we will have to change the update functions...

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

This was rtbc before the bot glitch.
BTW Dries look at #8 before commiting ;)

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Great. Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Security Advisory follow-up

Automatically closed -- issue fixed for 2 weeks with no activity.