Closed (fixed)
Project:
Pathauto
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
9 Oct 2006 at 10:20 UTC
Updated:
9 Apr 2007 at 06:46 UTC
Jump to comment: Most recent file
You shouldnt use an embedded update function in your .module. You should simply put that code into .install hook_update_x. That way the users are not forced to visit the settings page after update, but to call update.php as with all other modules out there.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | pathauto_remove_update.patch | 6.23 KB | greggles |
Comments
Comment #1
gregglesthanks for the tip - do you have a patch which achieves this?
Comment #2
gregglesComment #3
gregglesAs of 4.7 and 5.x these updates weren't actually updating anything but they still gave the messages that they were. So, I propose removing them.
Pathauto also has a need for a .install that will do some other things, but that's a separate issue.
Here's a patch which removes the unnecessary code (and therefore the unnecessary messages). Reviews and tests are welcome.
Comment #4
csevb10 commentedI'd second removing them, it seems harmless at least from a 4.7/5.0 perspective.
What elements would need to go into the .install?
Comment #5
gregglesThey all seem like "cleanup of old settings from prior installations" kinds of things so I don't think any need to go into a .install file. Does that seem like the case to you as well?
There are other things that do need to go into the install (like cleaning up patterns for cck nodes and also the _uninstall) but those are their own issues.
Comment #6
csevb10 commentedThat seems like the case to me. At this point, none of it is really relevant, so it's not really worth porting it into the install file for 4.7/5.0.
Comment #7
gregglesFixed in the 5--2 version of pathauto. Thanks profix898 and csevb10!
Comment #8
gregglesJust for the record, I forgot to remove this one function so I committed a patch that removed that....
Comment #9
(not verified) commented