Title + patch say all there is to say.

CommentFileSizeAuthor
#8 print_pdf.880400_1.patch368 bytesdrclaw
#7 print_pdf_lib_path.patch369 bytesdrclaw
#6 print_pdf_lib_path.patch349 bytesdrclaw
print_pdf.libraries.patch4.61 KBroderik

Comments

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Fixed

The module already supports that for a very long time.. In fact, the PRINT_PDF_LIB_PATH in the lines above your patch is defined as follows:
define('PRINT_PDF_LIB_PATH', 'sites/all/libraries');

But you're right.. It needs to be better documented. I've improved the INSTALL.txt file.

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented

LOL. That was silly of me, then.

One nitpick though: why not do a Libraries API call instead of defining the constant yourself? That way, a multisite installation can install their PDF conversion tool of choice in sites/SITENAME/libraries. Seems at least theoretically relevant to this module.

jcnventura’s picture

jcnventura
Primary language English
commented

Indeed, the multisite install is important.. The problem with adding the API at this moment is the problem of having to rename the library folders to something standard.. With the obvious annoyance that you can't have a folder for TCPDF 5.7 and 5.8 residing side by side.

I'll probably submit some patches to the Libraries API to remove that annoyance and then update the module when I am satisfied..

Multisite installs can always use the sites/all/libraries anyway. And I fail to figure out why someone would want to have a version of a tool for one site and a different version for another site.

João

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mrfelton’s picture

mrfelton commented
Status: Closed (fixed) » Active

I'm reopening this issue as IMO libraries api is still needed. The libraries API allows you to put the library in an of the standard drupal locations - including /profiles/profilename/libraries - this is very important when you are working with installation profiles.

drclaw’s picture

drclaw commented
StatusFileSize
new print_pdf_lib_path.patch349 bytes

Here's a quick fix (patch) for anyone using an install profile. Make things even easier by using drush make and patching in your make file! (that's what I'm doing)

drclaw’s picture

drclaw commented
StatusFileSize
new print_pdf_lib_path.patch369 bytes

Actually this one should work with drush make...

drclaw’s picture

drclaw commented
StatusFileSize
new print_pdf.880400_1.patch368 bytes

Nope, this one should work for sure though... =/ Sorry everyone.

pearcec’s picture

pearcec commented

The issue I have is that we use aegir, and drush make. We define what libraries we want during a make of the platform. If this doesn't get fixed to use Library API properly, than I have add my pdf library by hand every time I do a new build.

The original patch looks great to me. Not sure how why you need versioning of the directories.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Active » Needs review
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Fixed

I've committed the original patch. The module will still find the libraries in /sites/all/libraries even without the libraries module, but if that is available, it will be able to find them in the additional paths provided by it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.