"Need more choices" broken in poll module [#87957]

The "Need more choices" option doesn't work that well when you create a poll. I would guess that the behaviour should be as in 4.7.

These things seems odd to me (and differs from 4.7) :
* If the poll doesn't validate (e.g empty title), no extra choises are createt after pressing preview.
* The "Need more choices" checkbox is still checked after a preview.
* It's impossible to have more than 10 choices.
* If you uncheck the "Need more choices" checkbox, only 5 choises are rendered after a preview, even if you have filled in more than five.

Comment	File	Size	Author
#2	poll-fix_0.patch	925 bytes	eaton
#2
#1	poll-fix.patch	539 bytes	eaton
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

eaton CreditAttribution: eaton commented 8 October 2006 at 18:57

Status:

Active

» Needs review

File	Size
poll-fix.patch	539 bytes

1) Additional choices only show up when no validation errors are present. This is a side effect of the way the new FormAPI system works -- it doesn't build 'updated' versions of a form until the validation errors are gone, and I think this is a relatively minor issue. It wouldn't be able to submit in that state anyhow.

2) Looking into it.

3) Fixed.

4) Fixed.

Comment #2

eaton CreditAttribution: eaton commented 8 October 2006 at 19:20

File	Size
poll-fix_0.patch	925 bytes

...Aaaand the selection of the 'need more choices' checkbox is fixed as well.

Comment #3

chx CreditAttribution: chx commented 8 October 2006 at 19:22

Status:

Needs review

» Reviewed & tested by the community

The first default_value is a remnant of an ancient age when we needed to trick with form_builder to do multistep. The second is fixing ("noooo, input elements can't have a value!") went berserk. This input element never appears as checked hence the #value => 0.