Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.When you install Drupal and type in incorrect database settings you get an error message whose first paragraph looks like the following:
In order for Drupal to work, and to continue with the installation process, you must resolve all issues reported below. For more help with configuring your database server, see the installation handbook. If you are unsure what any of this means you should probably contact your hosting provider.
Issues include:
- "In order for Drupal to work" is just odd - that ought to be pretty obvious from the fact that it's not letting you finish installing Drupal :)
- There's a missing comma in the last sentence.
- The use of "probably" in the last sentence is a little weird too - either we recommend they contact their hosting provider or we don't...
This patch shortens and simplifies the text to the following:
To continue with the installation process, you must resolve all issues reported below. For more help with configuring your database server, see the installation handbook, or contact your hosting provider.
Make sense? I also attached a screenshot. Note that the text at the bottom of the error messages is weird too (and duplicates the text at the top), but that issue is being handled at #641008: Duplicated text in install error message and this patch is designed to go well with that one.
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | after.png | 4.37 KB | dcam |
| #15 | UI-text-clean-error-message-863594-7-D7.patch | 941 bytes | smussbach |
| #7 | UI-text-clean-error-message-863594-7.patch | 1010 bytes | mbrett5062 |
| #4 | clean-up-intro-db-error-message-2.patch | 941 bytes | David_Rothstein |
| #4 | install.png | 75.72 KB | David_Rothstein |
Comments
Comment #1
yoroy CreditAttribution: yoroy commentedTry to avoid to avoid words like 'must' (should, shouldn't etc).
"Resolve all issues below to continue installation. See the installation handbook for help with configuring your database server, or contact your hosting provider."
Oh, if it weren't for string freeze, there's still a whole lot of awkward wording going on :) I do agree this particular issue is of the buggy kind and I'm all for improvements to the installer experience. First impression etc.
Comment #2
David_Rothstein CreditAttribution: David_Rothstein commentedSure, we can simplify it even more... and I like your rewrite of the first sentence.
I'm not as sure about the second. The advantage of putting something like "For help with configuring your database server..." at the beginning of the sentence rather than the middle is that people who know they don't need help can stop reading there, and people who do need help have some preceding context to understand why we are linking them to the handbook right after that.
I am really unclear on what's going on with the string freeze - I keep hearing different things :) But http://drupal.org/drupal-7.0-alpha6 says we're still changing strings to add clarity and improve wording and that kind of thing, which I think this definitely falls under.
Comment #3
yoroy CreditAttribution: yoroy commentedComment #4
David_Rothstein CreditAttribution: David_Rothstein commentedRerolled patch - changed the first sentence, but kept the second sentence mostly the same (though removed a couple extraneous words). Also removed the
<p>tags that were surrounding this paragraph, as they seemed to serve no purpose except to break the layout :)Part of this may still be backportable to D7, especially since I'm not sure these strings ever get translated...
Comment #5
mbrett5062 CreditAttribution: mbrett5062 commentedThis issue was changed to D8 (8.x-dev).
The patch does not reflect this and still points to D7 file.
This should be changed to core\lib\Drupal\Core\Database\Install\Tasks.php
Line# 153
Setting back to 'Needs work'
Comment #6
mbrett5062 CreditAttribution: mbrett5062 commentedComment #7
mbrett5062 CreditAttribution: mbrett5062 commentedNew patch attached, updated to D8. Now points to correct file for Drupal 8.x-dev.
My first patch, hope I have done this correctly.
Comment #9
mgiffordThat seems much better worded @mbrett5062 it seems you dropped the "
" tags and wasn't sure that was intentional.
The patch looks good and applies nicely, but probably should have the paragraph tags back in unless I'm missing something.
I'm also sorry that this patch has been sitting here for almost 2 years with nobody commenting on it! That's really not a good introduction to Core.
Comment #10
mbrett5062 CreditAttribution: mbrett5062 commented@mgifford thanks for that review. The reason I removed the paragraph tags can be seen in @David_Rothstein comment #4 above. He and I saw they added no value, and just helped break up the layout.
Comment #11
mgiffordGreat.. I should have read more of the thread..
Comment #12
catchCommitted/pushed to 8.0.x, thanks!
Moving to 7.x for backport.
Comment #14
catchComment #15
smussbach CreditAttribution: smussbach commentedPatch for D7 backport is attached.
Comment #16
dcam CreditAttribution: dcam commented#15 is the exact same change that went into Drupal 8. Here's a screenshot of the altered message.
RTBC
Comment #17
David_Rothstein CreditAttribution: David_Rothstein commentedCommitted to 7.x - thanks!