Hello, the module is working great form me except:

"Registered authors can get notifications about comments on their nodes" its not working.

Node author is not getting notificacion unless he has commente his own node.

Files: 
CommentFileSizeAuthor
#8 774826_use_defaults_if_user_has_none.patch1000 bytesgreggles
PASSED: [[SimpleTest]]: [MySQL] 61 pass(es).
[ View ]
#5 comment_notify-862730-5.patch825 bytesdanylevskyi
PASSED: [[SimpleTest]]: [MySQL] 61 pass(es).
[ View ]

Comments

Melissamcewen’s picture

Same here.

neek’s picture

+ same with dev version 1.x

i think it can be critical, cause it is default option for node author.

subscribed.

danylevskyi’s picture

Priority:Normal» Critical

+1
I think it can be critical too.

danylevskyi’s picture

Status:Patch (to be ported)» Active

I think here (http://drupal.org/node/849780) is discussed same problem.

danylevskyi’s picture

Priority:Critical» Normal
Status:Active» Patch (to be ported)
StatusFileSize
new825 bytes
PASSED: [[SimpleTest]]: [MySQL] 61 pass(es).
[ View ]

Hi guys, here a solution of the problem!

Comment notify module sends email to the node's author after checking database table "comment_notify_user_settings". This table contains user ids and their settings for notifying. Module fills this table during "comment" and "user" hooks. And sometimes, especially new users, doesn't have their rows in the table and as a result module doesn't send mail.

My solution is very simple. It checks variable "node_notify_default_mailalert" if "comment_notify_user_settings" doesn't have the row with current user and depends on it's value sends or doesn't send mail.

Here my patch. Please, test it.
Sorry for my English.

neek’s picture

Status:Active» Patch (to be ported)

i will check it soon! spasibo

greggles’s picture

Status:Patch (to be ported)» Needs review

Better status.

greggles’s picture

Title:Node authors not geting notification» Node authors not geting notification unless they save their account page
StatusFileSize
new1000 bytes
PASSED: [[SimpleTest]]: [MySQL] 61 pass(es).
[ View ]

I fixed this a slightly different way in #774826: node_notify_default_mailalert not respected.

I've marked that as a duplicate of this. Could you folks test out the attached patch?

rfay’s picture

Priority:Normal» Critical
Status:Needs review» Needs work

Hmm. This is a critical I think.

However, without actually reviewing the code it appears to me that it doesn't work.

I created a node as one user, commented on it as another user, had the appropriate checkbox set in admin/settings/comment_notify. No email notification was generated to the node author.

Thanks for the excellent work on this everybody.

this_is_it’s picture

it's really good.
a finely, delicate patch.

rfay’s picture

I question my report in #9, so if it's not the same as other people's experience should be disregarded.

rfay’s picture

Status:Needs work» Reviewed & tested by the community

I've had this deployed on warmshowers.org for several months and it works as advertised. I have found nothing wrong with it.

Nice work, and thanks.

greggles’s picture

Status:Reviewed & tested by the community» Fixed

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.