I got annoyed looking at referrer reports that contained alternate domains (ie. for the site jeancrowder.ca, it wasn't identifying jeancrowder.org, jeancrowder.com or jeancrowder.net, let alone crowder.openconcept.ca as being internal references).

I wrote up a small patch for 4.6 & 4.7 that addresses this. Essentially there just needs to be some means to identify what domains should be considered internal and therefore removed from the query of external references.

CommentFileSizeAuthor
#1 statistics.module.46.patch2.41 KBmgifford
statistics.module.47.patch2.53 KBmgifford

Comments

mgifford’s picture

mgifford
he/him
Primary language English
commented
StatusFileSize
new statistics.module.46.patch2.41 KB

Just adding the 4.6 patch.

stevenpatz’s picture

stevenpatz
he/him
commented
Version: 4.7.3 » x.y.z

Features go in cvs

bdragon’s picture

bdragon commented
Version: x.y.z » 6.x-dev
Status: Needs review » Needs work

Autopatch Results:
patching file statistics.module
Hunk #1 succeeded at 354 (offset 43 lines).
Hunk #2 succeeded at 337 with fuzz 2.
Hunk #3 FAILED at 363.
1 out of 3 hunks FAILED -- saving rejects to file statistics.module.rej

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Version: 6.x-dev » 7.x-dev

Good point, we need this, but unfortunately not before D7.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Title: Some sites use multiple domains and the statistics module should have some way of addressing this effectively » Improve statistics for multidomain sites
mgifford’s picture

mgifford
he/him
Primary language English
commented

Why not? Or rather we should deal with this now to get it into D7?

mgifford’s picture

mgifford
he/him
Primary language English
commented
Version: 7.x-dev » 8.x-dev
Issue summary: View changes

This might just need to be closed. I haven't evaluated if it is still an issue or not.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Closed (outdated)

The Statistics module no longer looks at the Referer header, so this can't be a problem anymore.

(Interestingly, #1694922: Send more data to the statistics backend is looking to restore that. IDK why it was removed.)

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Closed (outdated) » Active

May be relevant again in the new module roadmap for the "transitions tracking" part of the plan at #3436823: Plan for Statistics 1.x.

quietone’s picture

quietone commented
Project: Drupal core » Statistics
Version: 8.5.x-dev » 1.0.0
Component: statistics.module » Code

Was checking for issue filed against outdated versions and found this.

If this could be relevant for the new module then let's move it to the contrib project so it can get some attention.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented

Wow, that's a good one, actually: multi-sites can exist in multiple DBs or a single one (e.g. with Domain Access). In the case of multiple DBs there is no real issue, as there is little case to be made that those are a single site.

However within a single DB, having per-site stats could really be relevant. I'm thinking of a site factory with hundreds of sites for France Televisions, where each one had different stakeholders and would be interested in their own specific sites.

And then, of course, one would need to also provide aggregate counts for site factory stats.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Active » Closed (duplicate)

Actually a duplicate of #7204: Allow domain aliases to be tracked by statistics module.