I was scanning the code for implementations of on-behalf target mappers to apply the same techniques to other modules we were hoping to extend with this functionality, and noticed that filefield.inc link.inc were not passing $target by reference in their hook_feeds_node_processor_targets_alter() hooks, as its cousins content.inc and taxonomy.inc were. I could not find a duplicate issue in the queue, so I wrote a trivial patch to correct this.

Review and feedback welcome.

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

davidwatson’s picture

Patch attached.

evNN’s picture

Reviewed and tested patch in #1 for "link" module as "filefield" was not in use at the time.

alex_b’s picture

Status: Needs review » Fixed

Committed, thank you: http://drupal.org/cvs?commit=394468

How did that ever work?

Hanno’s picture

Great! This issue also fixed an issue for the node_multisource module.
#857240: cck date fields of the parent feed become empty

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.