The [comment-link] token double escapes the subject by passing through check_plain and then through l() as text link. The patch to follow eliminates the check_plain

CommentFileSizeAuthor
#1 activity-855544--comment-link-dbl-escape.patch689 bytesrecrit

Comments

recrit’s picture

recrit commented
StatusFileSize
new activity-855544--comment-link-dbl-escape.patch689 bytes

patch attached

Scott Reynolds’s picture

Scott Reynolds commented
Status: Needs review » Fixed

http://drupal.org/cvs?commit=394462

thank you

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

recrit’s picture

recrit commented
Status: Closed (fixed) » Needs work

this appeared again in latest 6.x-2.x-dev and 6.x-2.0-alpha1. same fix needed.

more info - was re-introduced from this patch #372588: [comment-link] token incorrect for nodes with multiple pages (if many comments), specifically this commit:
http://drupalcode.org/viewvc/drupal/contributions/modules/activity/modul...

_shy’s picture

_shy
Primary language Ukrainian
Location Ukraine, Lutsk 🇺🇦
commented
Issue summary: View changes
Status: Needs work » Closed (outdated)

D6 reached its EOL back in February 2016, and there is no active release for D6 for this module anymore.
Development or support is not planned for D6. All D6-related issues are marked as outdated in a bunch.

If the issue remains relevant for D10+ versions, merge requests with proposed solutions for a new module version (D10+) are welcome in a new follow-up issue.

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.