Closed (fixed)
Project:
Mime Mail
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
13 Jul 2010 at 12:51 UTC
Updated:
8 Oct 2011 at 11:33 UTC
Jump to comment: Most recent file
Comments
Comment #1
sgabe commentedAt the moment Mime Mail doesn't specify the sender information but uses your sites default settings and Drupal uses only the e-mail address to set the sender in drupal_mail(). If the sender is empty Mime Mail will set it using the site's default name and e-mail address in mimemail_prepare().
drupal_mail() core default:
mimemail_prepare() default:
Changing version to HEAD.
Comment #2
sgabe commentedI am attaching a patch against current HEAD.
Comment #3
interestingaftermath commentedOh nice! So this patch should print the Site name as Name and the primary site e-mail as from email? Man, you're good! I will test it out and report back this evening.
Comment #4
sgabe commentedNo, this patch will allow you to specify the sender information on the module settings page.
Comment #5
interestingaftermath commentedThat's even better!
Comment #6
interestingaftermath commentedWorks like a charm! Thank you for your awesome support for this module. I've never seen a maintainer so active!
Comment #7
interestingaftermath commentedComment #8
sgabe commentedIt's not fixed until it's committed. Still needs some review.
Comment #9
interestingaftermath commentedOops. Sorry about that.
Comment #10
sgabe commentedSmall fix to use Mime Mail setting for default sender if sender is null, like the original behavior.
Comment #11
sgabe commentedNote that this patch fixes a bug for this issue. The array_merge() here doesn't allow to overwrite the headers, since the later value overwrites the previous one. So after all we pass the $sender to mimemail_headers() for nothing, the default headers added by drupal_mail() will overwrite these.
In the attached patch (in the previous ones too) the parameters of array_merge() are reversed and mimemail_headers() tries to overwrite these headers only if the $from parameter is set.
Comment #12
sgabe commentedCommitted to HEAD.
Comment #14
sgabe commentedChanging version.