Closed (fixed)
Project:
Feeds
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 Jun 2010 at 17:54 UTC
Updated:
3 Jan 2014 at 01:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
cglusky commented@rsoden I think this is the Data patch you mentioned. #836878: Support mapping of complex terms
Comment #2
cglusky commentedi suppose this gets into modularity of the architecture and what gets into the core module and what needs to be in it's own module etc. i think georss info in a feed is common enough these days to rate being in Common Syndication Parser.
@rsoden i am guessing if you want this to go anywhere you will need to provide simple tests to go along with the changes - asserting that this can grab points and placeneames from a feed etc. @alex_b can say for sure. and i wish i could help but i have not figured out simple tests for my own patches.
r,
c
Comment #3
alex_b commentedThis is a great start.
- I don't see where FeedsGeoLocation is being used.
- Tests would indeed be great here. Could be as simple as adding GeoRSS information and mapping into FeedsRSStoNodesTest.
- There's stray white space.
- There are unrelated modifications to FeedsDataProcessor
Comment #4
boris mann commentedAwesome. If this is similar enough to "common", then roll it in.
I would say that from a UI perspective, having a GeoRSS mapper might provide some more UI hooks to integrate into, and be more understandable for end users.
Comment #5
cglusky commentedfixing typo in title to help search index
Comment #6
Will White commentedUpdated patch to address some of the issues mentioned above.
- Removed FeedsGeoLocation class
- Removed stray white space.
- Removed unrelated modifications to FeedsDataProcessor
Comment #7
alex_b commentedThis is looking good. Minor stuff:
1.
$latand$london't seem to be reset after each iteration.2. Code style needs to be fixed:
$lat.' '.$lonComment #8
Will White commentedThis patch now resets those variables and fixed the style.
Comment #9
alex_b commentedTo be released w/ 6.x-1.0-beta5.
Comment #10
alex_b commentedFixed an issue where GUID was dropped, added tests. Will commit asap.
Comment #11
alex_b commentedCommitted, thank you http://drupal.org/cvs?commit=417538