Extra strict rules? [#826148]

Would it be possible to support coder format minor warnings for

- Line lengths over 80 chars
- Comments beginning with lowercase character
- Comments not ending in punctuation

There are only vague/indirect references to this in the coding standards, so it can't really be enforced on that basis I think, but some developers might like to pull their socks up a bit more than others?

Comments

Comment #1

danielb commented 13 June 2010 at 11:27

also this #150626: Check for proper inline comment formatting

Comment #2

aspilicious commented 17 June 2010 at 21:19

Line lengths over 80 chars is *only* a problem for comments in the header of functions.
Some comments like @see ...() don't need the dot.

So it is very hard to check those.

Comment #3

danielb commented 26 June 2010 at 00:31

I don't understand what you mean. Are you saying it is not possible to test how many characters a line has?

Comment #4

aspilicious commented 27 June 2010 at 19:46

It is possible but sometimes it is allowed to exceed 80 characters.
So you can't say that comments bigger than 80 characters aren't allowed in every case.

Example

/*
* Docblock can't exceed 80 characters
*/
function test() {
foo() // this can exceed 80 chracters foooooooooooooooooooooooooooooooooooooooooooooooooooo bar
}

Comment #5

psynaptic commented 13 June 2011 at 11:56

I want this.

I like what coder tough love is doing and want coder format to be able to format using these rules but they all are structured differently: coder tough love seems to extend coder, adding some more rules whereas coder format has its own parser which uses PHP's parser tokens.

I think what we need is a unified way of parsing Drupal source code. Maybe we just need to port coder_format to use grammar parser module?