Updating pathauto with drush removes i18n-ascii.txt from the module folder. How about adding /sites/*/libraries/pathauto as an alternative location for that file?
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | Selection_066.png | 53.5 KB | dave reid |
| #12 | 823648-pathauto-i18nascii-loc-D6.patch | 5.2 KB | dave reid |
| #9 | pathauto-drush-friendly-4.patch | 2.62 KB | henrrrik |
| #7 | pathauto-drush-friendly-3.patch | 2.62 KB | henrrrik |
| #6 | pathauto-drush-friendly-2.patch | 2.41 KB | henrrrik |
Comments
Comment #1
gregglesMakes sense to me. Care to write the patch?
Comment #2
henrrrik commentedHere's a patch. After discussing this with zoo33 I made it look for the file in these locations and in this order:
/sites/<site>/i18n-ascii.txt- Site-specific/sites/all/i18n-ascii.txt- Installation-wide<pathauto's module path>/i18n-ascii.txt- LegacyI originally thought
sites/*/librarieswas a good path, but this isn't a library and it also appears to be intended for external packages, so we decided against it.Comment #3
zoo33 commentedLooks rock solid to me. Nice improvement!
Comment #4
henrrrik commentedTurns out pathauto.admin.inc needs a patch too, I'll post it later this evening.
Comment #5
dave reidLooking good. We should probably also include an update to the README.txt along with the patch.
Comment #6
henrrrik commentedHere's an updated patch that takes care of pathauto.admin.inc and INSTALL.TXT.
Comment #7
henrrrik commentedtobiassjosten wisely suggested I refactor the "where's the file"-stuff into a separate function, so here goes.
Comment #8
tobiassjosten commentedWorks like a charm! I hate to nitpick on typos but there's a case error at line 44, "THe" -> "The". Other than that it's perfect.
Comment #9
henrrrik commented... and here's a patch with the typo fixed.
greggles: Sorry about changing the title back on you at #2, we must've been composing our comments simultaneously.
Comment #10
donquixote commentedYes, please, get this in!
EDIT:
See also #357037: Include a default i18n-ascii.txt and fix some transliterations. Now would be a chance to ship that file by default, and use the external folder to override it permanently.
Comment #11
gregglesI like donquixote's idea a bit...
Comment #12
dave reidRevised patch that rolls back a bug with #848250: parse_ini_file() problems with PHP 5.3 or disallowed and provides a little more help in the UI for where the files should be located, and which one is being used.
Comment #13
dave reidScreenshot of what it looks like in the UI.
Comment #14
dave reidCommitted to 6.x-1.x and thanks everyone! http://drupal.org/cvs?commit=404618
Comment #15
dave reidComment #16
dave reidAs a follow-up I also added support for using $conf['pathauto_i18n_file'] in your settings.php to be used as the top-preferred file if defined.
http://drupal.org/cvs?commit=404650