Create a pre-commit hook(s) that checks for common oopsies

Here: http://drupal.org/sandbox/JoshTheGeek/1143338
Right now it only checks for dsm() (really, only the first half: dsm( because of strstr).

And, move to that.

can you add dpm and others as well?

my vote for dpr(), db_queryd(), kpr() to be warned about.

I added the above, dprint_r() (long of dpr()) and kprint_r() (long of kpr()).
The functions to check for are now in an array at the beginning of the file.

Isn't it safer to check for a space before the function name as well?

I added the file to .giit/hooks and added +x permission, I get the following without being able to enter y/n

Oi! Are you sure you want to commit a dpm()? Type n to cancel. (y/n) [n] [master bc3e758] blokken toevoegen
 1 files changed, 3 insertions(+), 1 deletions(-)

Another one to include would be var_dump()

@attiks What is the benefit of checking for a space in front of a function name? Sometimes there might not be a space before the use of a debug function.

you're right, it should be a space or the beginning of the line. The reason I asked becuase otherwise it would complain my_dpm() function calls as well

BTW: if you follow drupal coding standards, there's always a space before the function name

does anybody else have the problem described in #7, or is it my install?

@attiks #7: I think that Git is not allowing input and just runs the script. I'm going to remove the confirmation and just cancel the commit, because there are almost no possible reasons to commit any of these. To get around it, you just have to move/rename the hook temporarily.
@attiks #10: exit(dpm($blah)); is coding standards valid, right? (Just an example, I dunno what dpm returns.)
@budda #9: I agree.

I will update this later today.

Another one is dd() and that one definitely has to have a preceding space or new line.

I fixed all of the above. It no longer prompts, and I added var_dump/dd/drupal_debug().

Once someone RTBCs this, I'll promote the project.

it's working for me, but can't we make the check more restrictive, see exit(dpm($blah)), moving the pre-commit hook isn't that user friendly ;p

so change the strstr to preg_match like this (not tested)

 if (preg_match("/\b" . $function . "\b/i", $line)) {

attiks:
From http://us2.php.net/preg_match : https://skitch.com/joshthegeek/r6ns4/php-preg-match-manual

All this will do is slow the script down on big commits.

I had a prompt about whether or not to continue, but you reported that git wasn't waiting, and just moving on. Moving the script may not be intuitive, but there are very few times you would even need to commit one of these. It tells you what function, so you can just grep $function( and get the whole line. Should I add the grep output?

josh i know it's slower, let's close this issue, i created a follow-up #1150016: Check for whitespace

We've been using this for the past week at Ixis and it's been a great reminder.