Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.As the sentence includes the preposition into
, the and pasting it
seems implicit to me.
It would be like saying copying and writing it into your paper book
; writing seems implicit.
Comments
Comment #1
apadernoComment #2
retester2010 CreditAttribution: retester2010 commented#1: 812810_copying_and_pasting.patch queued for re-testing.
Comment #4
drupal_was_my_past CreditAttribution: drupal_was_my_past commentedI disagree. I believe "copying and pasting it into" makes more sense than just "copying it into". "Copy and paste" is a pretty commonly understood action.
Comment #5
Kuldip Gohil CreditAttribution: Kuldip Gohil as a volunteer and commentedTo keep consistency Replaced all instance of "copying and pasting it to" to "copying and pasting it into"
Comment #6
Kuldip Gohil CreditAttribution: Kuldip Gohil as a volunteer and commentedComment #7
cilefen CreditAttribution: cilefen commentedThis is a bug if the language is wrong or confusing, and it must be fixed in 8.0.x first.
Comment #8
Kuldip Gohil CreditAttribution: Kuldip Gohil as a volunteer and commentedHi cilefen, I'm not getting what exactly needs to be fixed for this for this issue in D8, can you please mention in detail.
Thanks
Comment #9
cilefen CreditAttribution: cilefen commentedThe same text appears in Drupal 8 in core/modules/user/config/install/user.mail.yml. The backport policy dictates this must be fixed in Drupal 8 before Drupal 7.
Comment #10
Kuldip Gohil CreditAttribution: Kuldip Gohil as a volunteer and commentedThanks cilefen for the details.
Here is the D8 patch please review/test.
Comment #11
Kuldip Gohil CreditAttribution: Kuldip Gohil as a volunteer and commentedComment #12
Kuldip Gohil CreditAttribution: Kuldip Gohil as a volunteer and commentedPatches are ready, D7 is in #5, D8 is in #10.
Comment #15
akozma CreditAttribution: akozma commentedHere's a re-roll of the patch above (#10).
Comment #16
akozma CreditAttribution: akozma commentedComment #17
cilefen CreditAttribution: cilefen commentedNote that what is in patches is different from the exact intent of the issue, which is:
I happen to disagree with it a bit. I think the patches are better and we should be renaming "copying and pasting it to" to "copying and pasting it into".
I have tagged this "Needs issue summary update", which a novice can handle.
Comment #18
JulienD CreditAttribution: JulienD as a volunteer commentedThe patch applied correctly to the user.mail.yml file
Comment #19
webchickNice catch. Committed and pushed to 8.0.x. Thanks!
Moving to 7.x for backport.
Comment #22
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedPatch for D7.
Comment #23
cilefen CreditAttribution: cilefen commentedThis is one of those cases where
git diff --word-diff=coloris helpful for reviewing.There isn't much to say - the instances have been replaced with the correct verbiage.
Comment #24
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedI think based on https://www.drupal.org/node/1527558 we shouldn't change this in a stable release. It's user-facing text, and we really want to avoid breaking translations for that unless we really really need to.
The text is slightly inconsistent, but I don't think there's anything actually wrong with it as is, right?
Feel free to reopen for Drupal 7 if I'm missing something.