As the sentence includes the preposition into, the and pasting it seems implicit to me.
It would be like saying copying and writing it into your paper book; writing seems implicit.

CommentFileSizeAuthor
#22 d7_copying_pasting_user_mail_text_812810_22.patch1.45 KBsivaji_ganesh_jojodae
#15 d8_copying_pasting_user_mail_yml_812810_15.patch4.09 KBakozma
#10 d8_copying_pasting_user_mail_yml_812810_9.patch4 KBKuldip Gohil
#5 copying_and_pasting-812810-4.patch1.45 KBKuldip Gohil
#1 812810_copying_and_pasting.patch2.2 KBavpaderno

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 812810_copying_and_pasting.patch2.2 KB
retester2010’s picture

retester2010 commented

#1: 812810_copying_and_pasting.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 812810_copying_and_pasting.patch, failed testing.

drupal_was_my_past’s picture

drupal_was_my_past commented

I disagree. I believe "copying and pasting it into" makes more sense than just "copying it into". "Copy and paste" is a pretty commonly understood action.

Kuldip Gohil’s picture

Kuldip Gohil commented
Issue summary: View changes
StatusFileSize
new copying_and_pasting-812810-4.patch1.45 KB

To keep consistency Replaced all instance of "copying and pasting it to" to "copying and pasting it into"

Kuldip Gohil’s picture

Kuldip Gohil commented
Status: Needs work » Needs review
cilefen’s picture

cilefen commented
Version: 7.x-dev » 8.0.x-dev
Component: user interface text » user.module
Category: Task » Bug report
Status: Needs review » Needs work
Issue tags: +Documentation, +Needs backport to D7

This is a bug if the language is wrong or confusing, and it must be fixed in 8.0.x first.

Kuldip Gohil’s picture

Kuldip Gohil commented

Hi cilefen, I'm not getting what exactly needs to be fixed for this for this issue in D8, can you please mention in detail.

Thanks

cilefen’s picture

cilefen commented

The same text appears in Drupal 8 in core/modules/user/config/install/user.mail.yml. The backport policy dictates this must be fixed in Drupal 8 before Drupal 7.

Kuldip Gohil’s picture

Kuldip Gohil commented
StatusFileSize
new d8_copying_pasting_user_mail_yml_812810_9.patch4 KB

Thanks cilefen for the details.

Here is the D8 patch please review/test.

Kuldip Gohil’s picture

Kuldip Gohil commented
Status: Needs work » Needs review
Kuldip Gohil’s picture

Kuldip Gohil commented

Patches are ready, D7 is in #5, D8 is in #10.

mgifford queued 10: d8_copying_pasting_user_mail_yml_812810_9.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 10: d8_copying_pasting_user_mail_yml_812810_9.patch, failed testing.

akozma’s picture

akozma commented
StatusFileSize
new d8_copying_pasting_user_mail_yml_812810_15.patch4.09 KB

Here's a re-roll of the patch above (#10).

akozma’s picture

akozma commented
Status: Needs work » Needs review
cilefen’s picture

cilefen commented
Issue tags: +Needs issue summary update, +Novice

Note that what is in patches is different from the exact intent of the issue, which is:

Replace "copying and pasting it into" with "copying it into"

I happen to disagree with it a bit. I think the patches are better and we should be renaming "copying and pasting it to" to "copying and pasting it into".

I have tagged this "Needs issue summary update", which a novice can handle.

JulienD’s picture

JulienD commented
Title: Replace "copying and pasting it into" with "copying it into" » Replace "copying and pasting it to" with "copying and pasting it into"
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs issue summary update

The patch applied correctly to the user.mail.yml file

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Version: 8.0.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Nice catch. Committed and pushed to 8.0.x. Thanks!

Moving to 7.x for backport.

  • webchick committed b78a277 on 8.0.x 
    Issue #812810 by Kuldip Gohil, kiamlaluno, akozma, cilefen, rocket_nova...

  • webchick committed b78a277 on 8.1.x 
    Issue #812810 by Kuldip Gohil, kiamlaluno, akozma, cilefen, rocket_nova...
sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new d7_copying_pasting_user_mail_text_812810_22.patch1.45 KB

Patch for D7.

cilefen’s picture

cilefen commented
Status: Needs review » Reviewed & tested by the community

This is one of those cases where git diff --word-diff=color is helpful for reviewing.

There isn't much to say - the instances have been replaced with the correct verbiage.

David_Rothstein’s picture

David_Rothstein commented
Version: 7.x-dev » 8.0.x-dev
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs backport to D7

I think based on https://www.drupal.org/node/1527558 we shouldn't change this in a stable release. It's user-facing text, and we really want to avoid breaking translations for that unless we really really need to.

The text is slightly inconsistent, but I don't think there's anything actually wrong with it as is, right?

Feel free to reopen for Drupal 7 if I'm missing something.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.