The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.The views 2.9 or 2.10 update broke the inline javascript that conditionally hides the options form for each contrib slideshow plugin. Each plugin's option fieldset is always visible regardless of which plugin is selected in the "mode" dropdown. Patch to follow ..
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 781536-dependent-1.patch | 6.1 KB | redndahead |
| #1 | views_slideshow-781536.patch | 3.26 KB | fearlsgroove |
Comments
Comment #1
fearlsgroove commentedThis patch uses views dependent.js to show and hide the appropriate options forms when the mode is changed. There's a bit of trickery involved since fieldsets can't be used directly with dependent.js, as they have no unique ID and do not get the "#process" property applied.
Comment #2
redndahead commentedThanks didn't know there was a dependent.js to use. I'm currently in the process of rewriting views_slideshow for 3.x and have removed the fieldsets for various other reasons. So hopefully the hack won't be needed then.
I'm assuming you get a js error and that's why it's not working. Can you tell me what that error is? Mine works fine.
Comment #3
fearlsgroove commentedI don't get an error actually, it just doesn't execute the script (at least on Firefox 3.6) ... my guess is that views changed the way it displays the returned results such that it doesn't process inline javascript anymore. You're testing 2.x-dev and views 2.10?
Comment #4
redndahead commentedYep...I'm using FF 3.6 also. It would seem impossible to not let it use my js as it's just printed, but maybe since I'm not using a document ready there is a race condition. Anyway using dependent.js seems the way to go. It'll take me a bit to test your code, but I look forward to it.
Comment #5
redndahead commentedOk code tested and the patch attached will be committed. It adds a change to singleframe to use dependent.js for the pager options. It's a nice reduction in code I like it.