This'll hopefully mostly be covered by VCSAPI, but this is huge - we can't do commit listings or commit statistics without it.

Comments

marvil07’s picture

Project: Drupal.org infrastructure » Version Control API
Version: » 6.x-2.x-dev
Component: Git » Account Status

Actually we can map users, what it specifically needed here?

sdboyer’s picture

We already have a basic single-email mapping, yes. The concern driving this post is determining a method by which multiple email addresses can be associated with an individual account, a la github. I need to look at the account implementation in versioncontrol_git, which I haven't actually done yet. The real issue here is being able to make our commit statistics accurate enough that people will still be able to derive real meaning from them.

The primary issue I have is wanting to make the commit statistics rugged enough that they'll cope with the fairly-plausible scenario in which multiple email addresses can be associated with an individual account. I myself am one of the people this affects, as my ~/.gitconfig uses tech at samboyer.org, but my drupal email is drupal at samboyer.org, and I'd like it if my commits get credited regardless of which email address gets used.

sdboyer’s picture

Issue tags: -git phase 2 +git phase 3

This has been officially booted to phase 3 - we'll get along well enough with just the single email mapping initially.

marvil07’s picture

Component: Account Status » API module
Status: Active » Needs review
StatusFileSize
new2.07 KB

After #979040: Make pluggable the process of mapping of raw vcs data to Drupal users we have user pluggable mapping.

This patch adds integration with Multiple Email Addresses(AFAIK we'll be using that module at d.o for multiple emails).

This patch lacks of verification for multiple_email module to exists, so, where should we store(add module dependency) the plugin?
- versioncontrol, seems to be a bad place
- versioncontrol_git, bad place too, as other backends would want the same
- independent module, not sure, this is really tiny to be an independent module

This also open up a question: how dependencies should be handled at plugins? I think we can simply add the module names to the plugin and then just verify on the repository creation/edit form and also at mapping actions. If we go in that way(IMHO is a good alternative), this would be as easy as adding some more lines of code.

@sdboyer: does it sound like a good idea to you?

marvil07’s picture

Component: API module » User Mapping (plugins)
Josh The Geek’s picture

What happened to this? I think that any email in multimail will work with git now, but not certain. Is there any reason for this to still be open?

marvil07’s picture

Project: Version Control API » Drupal.org customizations
Version: 6.x-2.x-dev » 6.x-3.x-dev
Component: User Mapping (plugins) » Code
Status: Needs review » Closed (duplicate)

Yep, this is completely out-dated, the plugins handling this is on drupalorg customizations project, so, I can note really find the related issue, but it definitely a duplicated fixed.