Right now when you have several lines on your invoice and remove the first one by deleting its description and price, all subsequent lines disappear without warning.

Perhaps a "delete" checkbox could be placed next to each line.



#7 storm--items-07.patch1.43 KBjuliangb
PASSED: [[SimpleTest]]: [MySQL] 260 pass(es). View
#2 storm--758974-2.patch1.86 KBjuliangb
PASSED: [[SimpleTest]]: [MySQL] 58 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more


juliangb’s picture

Category: feature » bug

Definitely not the intended behaviour.

A neater way of doing the lines of the invoice would be to display one line, and add/remove lines via ajax or something similar.

juliangb’s picture

Status: Active » Needs review
1.86 KB
PASSED: [[SimpleTest]]: [MySQL] 58 pass(es). View

I think this will solve it - but disclaimer, I haven't tested this yet.

Let's see first whether the testbot likes it, then whether it has the intended result.

juliangb’s picture

Making sure this patch is still valid.

#2: storm--758974-2.patch queued for re-testing.

juliangb’s picture

*Bump* for review.

tchurch’s picture

Status: Needs review » Needs work

I tried this.

warning: Invalid argument supplied for foreach() in /home/sites/example.co.uk/public_html/central/sites/all/modules/storm/storminvoice/storminvoice.module on line 727.

Everything still disappears.

juliangb’s picture

Version: 6.x-1.x-dev » 6.x-2.x-dev

Needs to be fixed in 2.x first.

juliangb’s picture

Status: Needs work » Needs review
1.43 KB
PASSED: [[SimpleTest]]: [MySQL] 260 pass(es). View

Patch for review.

juliangb’s picture

I believe from my tests that this now fixes the issue.

I will wait 1 week before committing to let others test.

As a bug, this would be backported to 1.x.

kfritsche’s picture

works for me.

juliangb’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for the feedback.

Marking for commit.

juliangb’s picture

Version: 6.x-2.x-dev » 6.x-1.x-dev
Status: Reviewed & tested by the community » Needs review

Committed to 2.x.

Retest on 1.x.

juliangb’s picture

#7: storm--items-07.patch queued for re-testing.

dbt102’s picture

Version: 6.x-1.x-dev » 6.x-2.x-dev

Does not quite (completely) work for me...

I created a test invoice and posted three separate items. First Item I assigned a weight of 1, amount of $1000. 2nd a weight of 2, amount $2000. Then third item a weight of 3, amount of $3000. The printed invoice looked the way I expected.

Then I went and removed the third item (with weight of 3). And it removed that item leaving the other two.

However, when I removed just item with weight # 2 - by removing the description, price and weight - the last two items disappear.

And, starting over again with test items 1, 2 & 3 ... If I remove test item #1 - created 1st with weight of 1, it wipes out all three test items.

Am I doing doing something wrong? Do I need to enable ability to delete items from invoice in a preferences tab somewhere?

juliangb’s picture

dbt102: thanks for testing. It should work out of the box. Did you apply the patch manually or test the 2.x-dev release? Might be worth double checking that the fix was contained in the version you tested - as it worked ok in my tests, which were very similar to yours.

Would you be able to check and report back?

juliangb’s picture

Version: 6.x-2.x-dev » 6.x-1.x-dev
Status: Needs review » Fixed

I've retested this using the current 2.x-dev release without any modifications, and the setup described by dbt102 - all seems to now work. I suspect maybe the issue was that the -dev release hadn't been rebuilt when it was tested previously.

Given that, I have also committed to 1.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.