Move fieldset definition of settings form out of contrib and into main module

Here is the first stab at the patch. Not really happy about it because it does some funky things to get it to be compatible with older betas.

If we were to re-implement this I would require the form key to be the module name. So instead of $form['singleframe']['blah'] it would have to be $form['views_slideshow_singleframe']['blah']. The problem with changing this is that anyone that is currently using 2.x will lose the settings that they have in views_slideshow currently. I think that will make people grumpy. I don't know if it's possible to run an update query against the views variables, but if someone has an idea that would be great.

Here is the patch for the other option. This one needs an update function for the variable name changes.

OK we have a somewhat serious problem that needs a solution here. Currently the way this module is set up if you want to add a contrib module it must be named views_slideshow_*** We shouldn't limit it to this naming convention. Patch #2 removes this limitation, but at the same time it requires a change to all the variable names and an upgrade path doesn't look likely. So we have 2 choices that I see.

1) Make the changes with no upgrade path and tell everyone that they need to reset their settings after upgrading.
2) Make the changes and check for the time being adjust for the old values if they exist. This could be complicated especially with exported views.

Either way I don't think we're going to get much love from people. I'd love to hear any suggestions.

I feel like I'm talking to myself, but I have decided to go with #2.

I haven't been able to find a way to migrate old settings to new ones so when I make this change I'll post that the settings will have to be recreated and saved. This is going to cause problems all around, but this removes a severe limitation of this module.

If anyone has any ideas on how to migrate the settings I'd be happy to hear them.

Learned way to migrate old settings. Posting notes here so I can come back and look at them.

Look at lines 83-117 and see how we can replace the variable on init.
http://drupalcode.org/viewvc/drupal/contributions/modules/views/plugins/...

Will need some good testing, but this should make for a release of beta-3.

Here is the final patch that's to be committed. This patch will make it so the user won't have to update anything.

This has some indentation cleanups.

This has been committed.