The commit on Feb 26 moved the adding of the js files and css files to the views_slideshow.module file. These should be moved back. Not all plugins for views slideshow will use these files. And views_slideshow.module should be kept as much of an api for rotating views items as possible.

CommentFileSizeAuthor
#3 736400-cycle_roll_back-3.patch4.7 KBredndahead
#2 736400-cycle_roll_back-2.patch4.71 KBredndahead
#1 736400-cycle_roll_back-1.patch4.76 KBredndahead

Comments

redndahead’s picture

redndahead commented
Status: Active » Needs review
StatusFileSize
new 736400-cycle_roll_back-1.patch4.76 KB

Here is the patch for this. Moved it into hook_init(). May help with caching.

redndahead’s picture

redndahead commented
StatusFileSize
new 736400-cycle_roll_back-2.patch4.71 KB

Remove unnecessary spacing

redndahead’s picture

redndahead commented
StatusFileSize
new 736400-cycle_roll_back-3.patch4.7 KB

Aargh missed some.

redndahead’s picture

redndahead commented
Status: Needs review » Fixed

Committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.