Hi,
I was gearing up to write my own "hacked" solution to integrate content of a Drupal image gallery with a simpleviewer display (I was going to re-purpose some very rough code that I used to fetch images from gallery2 and display them with simpleviewer). Needless to say, I was so excited to find this module, as it seems to do exactly what I needed (and as an actual Drupal module... which I would have not been able to crank out myself)!
I noticed that the module code is pretty easy to sift though and tweak as needed (adding other parameters/options to be passed to simpleviewer, etc.). As I'm trying to use SV 2, I noticed that several options (new/unique to SV 2) were not available in the otherwise comprehensive set of module options (admin/content/fgallery), so I found myself doing a lot of manual tweaks inside function theme_flash_gallery() and function flash_gallery_xml_options(). In this process it occurred to me that it might make sense to simply add some free-form textareas (at admin/content/fgallery) to allow users to enter arbitrary XML and HTML options/parameters to be passed to simpleviewer.
The attached patch is a (very simple) preliminary effort to add these options in the "miscellaneous" group of module conf options.
Please note that I'm pretty new to Drupal development (and general php development for that matter), so I'm not sure if this patch is on-par with certain standards... but I just thought I'd share what I have and have been using. I also suppose there may be a good reason why the module developer(s) may have intentionally left this kind of option out (security reasons, fact that incorrect structured entries can break the gallery display, etc.).
Anyway, just tossing it out there... maybe the idea is useful somehow.
Cheers,
Ryan
| Comment | File | Size | Author |
|---|---|---|---|
| add_custom_user_xml_html_options.patch | 2.4 KB | rjacobs |
Comments
Comment #1
danieltome commentedHi Ryan,
Nice work!
Thanks for implementing this patch. I will look into adding this option, it will definitely be useful when SV 3 comes out.
cheers,
Dan