This patch does this, which makes this awesome module even more awesome!

CommentFileSizeAuthor
#9 mail_logger_rules-1.1-patched3.patch2.84 KBgnindl
#4 mail_logger.rules_.727210.4.patch9.87 KBaaron
mail_logger.rules_.patch10.29 KBaaron
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aaron’s picture

aaron CreditAttribution: aaron commented

for reference, http://code.iamcal.com/php/rfc822/full_regexp.txt has a more complete regex pattern for extracting the email from the 'to/from' fields. might add that for better token rfc822 support, though in an included file. also, the 'recipient' token will only grab the first recipient if more than one is given.

aaron’s picture

aaron CreditAttribution: aaron commented

also, i cleaned up much of the code, ensuring t()'s and check_plain/markups all around.

aaron’s picture

aaron CreditAttribution: aaron commented

and added media_logger_load($mlid), but i didn't drop that into hook_menu. maybe a followup patch, maybe not. :P

that's all for now.

aaron’s picture

aaron CreditAttribution: aaron commented
Issue tags: +rules integration, +token integration
FileSize
mail_logger.rules_.727210.4.patch9.87 KB

This adds a condition to match against the mail key, making rules integration even more useful.

litwol’s picture

litwol CreditAttribution: litwol commented
Status: Needs review » Fixed

Ty

kentr’s picture

kentr CreditAttribution: kentr commented

I'm not seeing an option for this in the Event choices on Rules, Triggered Rule add form. Should it be there?

barckhoff’s picture

barckhoff CreditAttribution: barckhoff commented

I tried installing this -- got many errors on the patch. Then I notice that it looks like most, if not all, of these changes are incorporated in the 6.x-1.x-dev version?

From the straight 6.x-1.x-dev version (with no patch installed) I got the following error when looking at Triggers for Mail Logging:

# warning: array_merge() [function.array-merge]: Argument #1 is not an array in /var/www/jobs.kemri/sites/all/modules/mail_logger/mail_logger.module on line 261.

barckhoff’s picture

barckhoff CreditAttribution: barckhoff commented
Status: Fixed » Needs work
gnindl’s picture

gnindl CreditAttribution: gnindl commented
Version: 6.x-1.x-dev » 6.x-1.1
FileSize
mail_logger_rules-1.1-patched3.patch2.84 KB

The patch from comment #4 is fine but the committer forgot to include the additional file mail_logger.rules.inc. This is where all rules conditions and events are defined. Compiled a new patch with the new file removing already committed changes.

gnindl’s picture

gnindl CreditAttribution: gnindl commented
Category: feature » bug
Status: Needs work » Needs review

Changed status

fizk’s picture

fizk CreditAttribution: fizk commented
Category: Bug report » Feature request
Issue summary: View changes

gnindl, support for other modules is a feature request.

  • NancyDru committed 51a5ce0 on 6.x-1.x 
    Issue #727210 by gnindl - Add Rules, Actions, and Token support.
NancyDru’s picture

NancyDru
she/her/hers
Primary language English
Location Boston
CreditAttribution: NancyDru commented
Status: Needs review » Fixed

Applied your patch.

jennifer.chang’s picture

jennifer.chang CreditAttribution: jennifer.chang commented
Category: Feature request » Bug report
Status: Fixed » Active

The patch committed contains a CVS Id tag, and the header in the mail_logger.css file claims it is an "Install and update functions for Mail Logger module."

  • NancyDru committed ac73711 on 6.x-1.x 
    Issue #727210 - Clean up last patch.
NancyDru’s picture

NancyDru
she/her/hers
Primary language English
Location Boston
CreditAttribution: NancyDru commented
Status: Active » Fixed

Fixed it. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.