The vertical_tabs.css exists, but still puts the tabs on the left side, instead of right side.

CommentFileSizeAuthor
#10 Tabs on Right Side.png73.69 KBr13ose
#6 725824-verticaltabs-rtl-css-D7.patch754 bytesdave reid
#4 vertical_tabs-rtl-css-725824-3.patch889 bytesAnonymous (not verified)
rtl-vtabs.jpg42.38 KBAnonymous (not verified)

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Can you check if Drupal 7 has the same behavior?

Anonymous’s picture

Anonymous (not verified) commented

No I didn't. I'm not on D7 yet.

Anonymous’s picture

Anonymous (not verified) commented

I noticed that the RTL css is overriden by LTR css:

vertical_tabs-rtl.css:

.vertical-tabs-list

is override by
vertical_tabs.css:

div.vertical-tabs ul.vertical-tabs-list

It's because of the extra CSS selectors, they have higher browser priority.

So the fix is probably to put this in RTL.css:
div.vertical-tabs ul.vertical-tabs-list

Anonymous’s picture

Anonymous (not verified) commented
Version: 6.x-1.x-dev » 6.x-1.0-rc1
Status: Active » Needs review
StatusFileSize
new vertical_tabs-rtl-css-725824-3.patch889 bytes

Attached is my working vertical_tabs-rtl.css patch for RC1. Great module!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: RTL CSS not working properly » Vertical tabsRTL CSS not working properly
Project: Vertical Tabs » Drupal core
Version: 6.x-1.0-rc1 » 7.x-dev
Component: Code » javascript
Status: Needs review » Patch (to be ported)

Fixed in CVS.
http://drupal.org/cvs?commit=344126

I took a look at D7's misc/vertical-tabs-rtl.css and it looks like it will need the same fix. Could you possibly re-roll this and I'll review it?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 725824-verticaltabs-rtl-css-D7.patch754 bytes

Nevermind, I went ahead and patched it.

aspilicious’s picture

aspilicious commented
Status: Needs review » Needs work

#6 doesn't work at all...

Maybe it is cause of the double '-'
In drupal 6 it was vertical_tabs...

james.elliott’s picture

james.elliott commented

subscribe

nod_’s picture

nod_
Primary language French
Location Lille
commented
Component: javascript » CSS
Status: Needs work » Needs review

How much of this is still relevant?

r13ose’s picture

r13ose commented
Issue summary: View changes
StatusFileSize
new Tabs on Right Side.png73.69 KB

I have tested this issue out, and seems the tabs are on the right side for me. Attached is a photo of what I see in Drupal 7.42-dev.

cilefen’s picture

cilefen commented
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

This needs an issue summary update explaining the issue in more detail and providing before- and after screenshots.

An evaluation of whether this is a Drupal 8 issue according to the backport policy is also needed.

r13ose’s picture

r13ose commented
Status: Needs work » Closed (fixed)

I tested this on the Seven and Stark Themes in 7.42-dev.

To test this: