Code standards review

After #879858: Unify entity C(R)UD most of underscored methods are changed to backend<crud_operation>(), so less things to do here.

Leaving this open to actually make a review across all the code and another one with coder module.

let's do this review before 6.x-2.0

Not a blocker, but let's do this before opening a 7.x-2.x (leaving the tag only to remember that)

The patch is for D7 I think(applies there), let the bot try it.

Sorry for the noise, I do not know why testbot is not triggering the coder review for versioncontrol branches nor patches. Back to original state.

#8: versioncontrol-coding_standards-723962-7.patch queued for re-testing.

Sorry for the noise again. After talking with jthorson, now I have it clear: testbot runs coder review only for branches, not for patches, and that seems to be disabled from time to time, so I guess it's not reliable.

After running it locally I see this patch makes a good progress, but it's halfway there, so moving back to original state.

Thanks for taking the time to push this :-)

+++ b/commitlog/includes/views/commitlog.views_default.inc
@@ -10,14 +10,14 @@
-      $view_name = substr($file->name, 0, strrpos($file->name, '.'));
+      $view_name = drupal_substr($file->name, 0, drupal_strrpos($file->name, '.'));

There was a minor bug here, drupal_substr() exists, but drupal_strrpos() not.

+++ b/includes/views/handlers/versioncontrol_handler_field_operation_message.inc
@@ -26,10 +26,10 @@ class versioncontrol_handler_field_operation_message extends views_handler_field
-    return preg_replace('/#(\d+)\b/ie',
-      "strtr('<a href=\"!url\">#\\1</a>', array('!url' => strtr(\$this->options['issue_tracker_url'], array('%issue_id' => \\1))))",
-      htmlspecialchars($message)
-    );
+    $matches = array();
+    preg_match('/#(\d+)\b/i', $message, $matches);
+    $link = str_replace('%issue_id', $matches[1], $this->options['issue_tracker_url']);
+    return l($matches[0], $link);

Sadly, that code is not really equivalent to the original one. It is a multi-replace, we can not assume one issue ;-) and we need to link the id and actually show all the message, which is not happening after that hunk.

I wrote a little piece to avoid e preg_replace() modifier.

Also, I added some more minor doc issues for coder to be happier.

I'll add it after bot re-confirms it.

Added to 7.x-1.x and to 6.x-2.x after some minor conflict resolution.

It feels so good to close 2 years old issues, thanks Howard!

The patch applied to D6 FTR.