When the Timer delay setting is 0, the Views slideshow does not cycle automatically, only manually using the previous/next controls. The pause/resume controls don't make sense in that case and should be removed, IMO.

CommentFileSizeAuthor
#2 718144-hide_pause-1.patch1.14 KBredndahead

Comments

redndahead’s picture

redndahead commented
Priority: Normal » Critical

Marking as critical to look at before release.

redndahead’s picture

redndahead commented
Status: Active » Needs review
StatusFileSize
new 718144-hide_pause-1.patch1.14 KB

Here is a patch to fix it.

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented

Didn't test the patch yet, but it looks sensible. One thought: can a situation exist where $options['singleframe']['timeout'] is not set or NULL, causing the if statement to return FALSE when it should return TRUE? In that case, if ($options['singleframe']['timeout'] === 0) { would be appropriate; if not the patch should be fine.

redndahead’s picture

redndahead commented

That shouldn't be the case, but it may be safer to add the comparison. Thanks

redndahead’s picture

redndahead commented
Status: Needs review » Fixed

This has been committed, thanks.

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented

Thank you for including my suggestion in this great module.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.