Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Quoting joachim on the main thread:
Only one sidebar now? How easy is it to modify the theme to put it on the left instead of the right? If we're aiming to be easily modifiable, changing sidebars from side to side is something people will want to do.
http://drupal.org/node/683026#comment-2542558
I'm calling this a bug because I think otherwise Bartik's too prescriptive to be the default theme.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | region.patch | 3.32 KB | chx |
| #11 | region.patch | 0 bytes | chx |
| #9 | 713444-8.bartik.second-sidebar.patch | 2.71 KB | mikey_p |
| #7 | bartik-empty-1st.png | 76.96 KB | emmajane |
| #7 | bartik-empty-2nd.png | 76.99 KB | emmajane |
Comments
Comment #1
joachim CreditAttribution: joachim commentedI've committed a fix to this on github.
Comment #2
willmoy CreditAttribution: willmoy commentedFor ease of reference, comment on the main thread:
http://drupal.org/node/683026#comment-2597716
and the fix is here:
http://github.com/joachim-n/Bartik/commit/13180dbfe12bda2f6aa3396a22bfb6...
Comment #3
willmoy CreditAttribution: willmoy commentedNow we have a bartik project, moving there. Marking as critical because I assume it blocks bartik in core.
Comment #4
willmoy CreditAttribution: willmoy commentedMarking as needs review because joachim has code for this.
Comment #5
yoroy CreditAttribution: yoroy commentedI tried to recreate this as a patch. Can't read patches well so got confused with the part in layout.css, is there a link on that github page that exports the fix as a patch?
Work in progress patch, needs review for bot, then needs work to add the changes in layout.css
Comment #6
joachim CreditAttribution: joachim commentedHere's a proper patch of the whole change.
Changing issue name too.
As I remarked in the main Bartik issue, there remains a problem with the full widths across the page not adding up which my patch does not address as I'm not sure what jensimmons' intentions are here.
Comment #7
emmajane CreditAttribution: emmajane commentedThe patch is fantastic. Screenshots attached #1,2,3.
HOWEVER, when the "display content in hidden regions" is turned on, the layout fails miserably. See attached screenshots #4,5.
If this doesn't matter because people should just turn that bit off, please mark the patch "reviewed and tested by the community" (which means Jen should roll it into the main theme).
If this DOES matter (which it probably does?) then the patch will need to be updated to fix the Lorem ipsum block.
Comment #8
jensimmons CreditAttribution: jensimmons commentedWe will be removing the dummy content as per webchick's request — so we don't need to fix the layout with that content.
Comment #9
mikey_p CreditAttribution: mikey_p commentedThis should fix the git prefix issue
Comment #10
jensimmons CreditAttribution: jensimmons commentedI'm still getting errors for this patch.
patching file bartik.info
Hunk #1 succeeded at 18 (offset -1 lines).
patching file css/layout.css
Hunk #2 FAILED at 113.
1 out of 2 hunks FAILED -- saving rejects to file css/layout.css.rej
patching file page.tpl.php
I'm going to try and roll it from scratch.
Comment #11
chx CreditAttribution: chx commentedRerolled against HEAD
Comment #12
chx CreditAttribution: chx commentedComment #13
jensimmons CreditAttribution: jensimmons commentedThat chx reroll works great. Thanks everyone.
As soon as I figure out how to properly commit a patch, I will.
Comment #14
jensimmons CreditAttribution: jensimmons commentedCommitted!
(my first cvs commit)(ever)