For the Print Mail module, when I’m in the page to send content to a friend, the form requires me to input information in the “Send to,” “Message,” and “Your Email (if anonymous)” fields in order to “Cancel.” Meaning, if I didn’t enter any information in those fields and decide to cancel, it will display a required message. However, when I do enter information in those fields and decide to cancel, it cancels properly—sending me back to the node page that I wanted to send. This shouldn’t happen because users often change their minds without entering any information. If those fields are blank and a user clicks the cancel button, he should be sent to the original node without being notified that fields are required. Moreover, I would like to see a “Send Myself a Copy” option. Thanks for taking the time to read this issue.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | print_mail-6.x-cancel_button.patch | 8.21 KB | AlexisWilke |
| #8 | print_cancel_703296_8.patch | 1.72 KB | gagarine |
| #9 | print_cancel_703296_8.patch | 1.72 KB | gagarine |
| #6 | cancel_btn_703296.diff | 1.24 KB | gagarine |
| #5 | cancel_btn_#703296.diff | 1.24 KB | gagarine |
Comments
Comment #1
jcnventuraAre you really using version 6.x-1.10? This problem was fixed in 6.x-1.4 !?
In case you're running an old version, please upgrade the module. If not, then something is wrong with your setup, as I've just tested this and it works fine without requiring any data in those fields..
João
Comment #2
jcnventuraNo further info in more than two weeks. Closing the issue.
João
Comment #3
lebachai commentedSorry, but I'm able to duplicate this issue in print 1.12 (the currently recommended version). Any clues about what the issue may be? If it's on my end, that's fine--I just want to be able to fix it.
Comment #4
gagarine commentedI can confirm this bug.
Comment #5
gagarine commentedComment #6
gagarine commentedThe file don't work don't know why...
Comment #7
gagarine commentedI found a mistake.. patch coming...
Comment #8
gagarine commentedThis one works..
EDIT: sorry for double posting... drupal.org bug
Comment #9
gagarine commentedThis one works
Comment #10
dstolPatch works as advertised.
Comment #11
AlexisWilke commentedI confirm that the patch works.
However, it defines a 2nd instance that overwrites the first instance of the Cancel button.
Plus, the submit function should be unindented to be correct.
The attached proposes the same patch with those two fixes.
Thank you.
Alexis Wilke
P.S. note that it looks like a lot of code was changed, this is because of the indentation fix.
Comment #12
rv0 commentedpatch in #11 does the job for me.
thanks!
Comment #13
nclavaud commentedfacing the same issue.
using patch #11, cancelation (and other actions) worked as expected.
thx!
Comment #14
jcnventuraActually, only two lines in that patch are needed.
This used to work before quite nicely until I accept the patch in #707534: Email to a friend form needs required fields, and I forgot to adapt the cancel option to ignore the errors when validating.
I've committed a fix to git.
Comment #16
escoles commentedJust to be clear: We have to install dev to get this patch, right?
Shouldn't the status be 'reviewed & tested by the community', not 'fixed'?
EDIT: Note that upgrading to the dev version may expose the 'access denied' bug described here:
http://drupal.org/node/605264
So IMO the better part of valor is to either sort out and apply the appropriate patch or not try to fix this problem.
Comment #17
dstolFixed is the appropriate status as the code has been committed.
A release hasn't been created since the issue was fixed so you'll need to download the nightly dev.