Custom inline style properties overwritten when using CSS Compressor

I can confirm this issue.

simplenews-newsletter-body.tpl.php

<h2 style="color: red;"><?php print $title; ?></h2>
<?php print $body; ?>

mail.css

h2 { font-size:8px; }

in the test newsletter the styles are merged just fine

<h2 style="color:red;font-size:8px;">Lorem ipsum (700996) - 1</h2>

but in the newsletter sent by cron the style is replaced by the definition in mail.css

<h2 style="font-size:8px;">Lorem ipsum (700996) - 1</h2>

I'll dig deeper into this.

@-Mania-: Will you help me test if I come up with something?

@-Mania-: Please make sure that Simplenews uses the modified template files. I could reproduce this, when Simplenews couldn't load my custom newsletter template files. I think that is the case in your issue too, so it's not a MimeMail problem after all.

Simple put something like this in the template file:

<h1>Made by my default theme</h1>
<h2 style="color: red;"><?php print $title; ?></h2>
<?php print $body; ?>

You'll have to see it in the message.

Followed your lead in #5 and retested this. Issue confirmed as valid. I missed the bug in my first test...

To reproduce:

1. Enable the CSS Compressor.
2. Declare a style rule in mail.css.
3. Define the same property with a different value for the same selector as inline style.
4. Send a test message.

The inline property's value will be overwritten with the one defined in mail.css. I couldn't reproduce this at first because I used different properties. In that case the CSS Compressor concatenates the properties just fine.

I am changing the title to a more accurate one.

CSS Compressor creates arrays from the style attributes, than uses array_merge() to merge the existing style information with the new one. According to the behavior of the function:

If the input arrays have the same string keys, then the later value for that key will overwrite the previous one.

I think we can simply commute the two arrays, so the old one will overwrite the new one and we can preserve the existing inline values. I am attaching a patch and changing the version, since patches should be made against HEAD.

@-Mania-: Try the attached patch and report back, please.

Please, set the issue status to RTBC, if it works.

Committed to HEAD.

I am afraid we have to revert this commit and find another workaround because this approach ignores the CSS style precedence, see #882960: CSS Mail Style Sheet Overrides for more information.

Could you please try #885006: Update Emogrifier (mimemail_compress) instead?

Well, I didn't test #796510: Update CSS Compressor for this issue, but I can imagine that it solves this issue too. Did you try it?

I did a quick test and it's not working.

Yeah, sorry, I missed that issue where the emogrifier update is buried. I've answered this issue's question in the other #796510: without inventing a completely new system, emogrifier doesn't keep inline style properties and always overwrites them. A 'completely new system' could look like retrieving the XPath to all elements with style attribute (before starting to process the CSS styles!) and dynamically adding them to the list of selectors. Since they're full path expressions from the root to the element, they would have the heighest weight and therefore be applied last (after sorting).

Voilà, here's a patch that does what I said. For now, it's a patch against the original emogrifier, i.e. if you decide to apply/port it to mime_compress you have to restore the merge order of style attributes first!

smk-ka: Please, would you make a patch against current HEAD?

Thank god it's friday!

Changing status, since we have a patch that needs testing.

@smk-ka: Sorry that it took me so long to review your patch. I just tested it, applies fine and seems to work fine.

Committed, thanks!