I went to localize.drupal.org today to see if I could contribute to the Spanish translation of Drupal 7. It has the Drupal 7.x-alpha1 version loaded currently.

There were LOTS of strings to be translated that had the word "node" in them, although according to http://drupal.org/node/604342 we are not supposed to be using the word "node" any more in the user interface. It ran to 3 pages, at 30 per page, so somewhere between 60 and 90 strings containing the word "node".

Some of them are from tokens, so we probably won't fix those (see #678012: Tokens should not use the word "node" in human-readable descriptions for what we did for node.tokens.inc - may need to do something similar for comment.tokens.inc?).

The rest probably need to be fixed. For reference, I exported the POT files for Drupal 7 -- it comes as a TGZ archive with each module in a separate POT file, unfortunately. (Technically, they are PO files for Spanish, but without the Spanish translations in there.)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon’s picture

Status: Active » Needs review
Issue tags: +Needs usability review, +Usability, +ui-text, +ui-text usability
FileSize
6.68 KB

I went through these... Aside from tokens, which I'm leaving as-is mostly (see above), I found about 6 places that needed fixing.

Here's a patch.

moshe weitzman’s picture

Status: Needs review » Needs work

i could be wrong, but 'content item' is not a standard phrase in drupal. you could use 'post' in some cases, and 'content type' in the field api case.

yoroy’s picture

The same http://drupal.org/node/604342 suggest to use 'piece of content' for node and that's what we're doing elsewhere in the ui. (Don't use 'post' as a noun)

jhodgdon’s picture

Status: Needs work » Needs review

Moshe: I didn't write the guidelines. Nor do I agree with them, necessarily... but we aren't using either node or post as a noun to describe a node, except in coder-facing documentation. And in the case of tokens, because pretty much none of them make a bit of sense without the word node. We are using content item now.

I personally think it makes a lot of the writing in Drupal UI and help text VERY awkward, but as I said, this was not my decision.

Regarding the idea for the field API of using "content type", I was informed in no uncertain terms when redoing the help for the field API never ever to say that we attach fields to content types or vocabularies, because the fields are attached to the individual nodes/terms.

moshe weitzman’s picture

you got bad information i think. on these field ui pages, we are attaching fields to 'bundles' which are equivalent to content types when discussing nodes. we do not attach fields to individual nodes.

jhodgdon’s picture

Status: Needs review » Needs work

Right... Hmmm...

The Field module help currently says:

The Field module allows custom data fields to be attached to Drupal entities (content nodes, users, taxonomy vocabularies, etc.) and takes care of storing, loading, editing, and rendering field data.

This is not good as it is.

If we use the word entities here, then technically the entities are taxonomy terms, user objects, nodes, and comments, right? I mean, the field definitions are attached to content types (for nodes and comments), vocabularies (for terms), and to the user account system (for user objects). The field instances are attached to the entities node, comment term, and user objects.

In the field UI help, which is definitely aimed at the non-technical user, and hence avoided the terms entities, attach, bundles, etc., we said (after much debate):

Fields can be defined at the content-type level for content items and comments, at the vocabulary level for taxonomy terms, and at the site level for user accounts.

So I agree that the suggested change to field.module in the above patch is wrong. I'm just not sure how it should be rewritten so that it is correct.

jhodgdon’s picture

Status: Needs work » Needs review
FileSize
6.71 KB

OK, here's a proposal:

The Field module allows custom data fields to be defined for entity types (entities include content items, comments, user accounts, and taxonomy terms). The Field module takes care of storing, loading, editing, and rendering field data. Most users will not interact with the Field module directly, but will instead use the Field UI module user interface. Module developers can use the Field API to make new entity types "fieldable" and thus allow fields to be attached to them.

Here's a patch with the above change (and the other changes from the previous patch).

reglogge’s picture

Shouldn't it say

Optionally specify an alternative URL by which this content item can be accessed...

in the part of the patch for path.module?

Sorry, but I can't reroll the patch right now due to technical issues with my pc.

jhodgdon’s picture

Actually, I thought it was better without "item". This is on the form alter for the node editing form, by the way, so I think the context is pretty clear.

cosmicdreams’s picture

+1 for excluding the word "item".

amc’s picture

retester2010’s picture

#7: 690622-update.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Needs usability review, +Usability, +ui-text, +ui-text usability

The last submitted patch, 690622-update.patch, failed testing.

jhodgdon’s picture

Status: Needs work » Needs review
FileSize
6.7 KB

Here's a reroll that should hopefully apply.

jhodgdon’s picture

Issue tags: +String freeze

tagging

Bojhan’s picture

Status: Needs review » Reviewed & tested by the community

Since we dont use "node" anymore, without this fix it will be confusing.

jhodgdon’s picture

Thanks Bojhan for reviewing.

Perhaps we should hit the test bot and make sure this doesn't break anything -- it's been a while since the last test of that issue?

jhodgdon’s picture

#14: 690622-reroll.patch queued for re-testing.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

And thanks for working on string freeze patches. :)

Status: Fixed » Closed (fixed)
Issue tags: -Needs usability review, -Usability, -String freeze, -ui-text, -ui-text usability

Automatically closed -- issue fixed for 2 weeks with no activity.