I noticed that for instance the Task Description is before the Assigned and Project manager fields. Since Description is a textarea field that can contain several lines, it would be better when it always appears last. It would also be better when "Description" label has text-adjust left and the descriptive text under it:
div.stormbody div.label {
text-align:left;
margin: 10px 0 0;
}
div.stormbody div.value {
margin: 35px 0 0;
}| Comment | File | Size | Author |
|---|---|---|---|
| #20 | storm_issue_688086_comment_20.patch | 555 bytes | francewhoa |
| #17 | storm_issue_688086_comment_17.patch | 590 bytes | francewhoa |
| #15 | storm_issue_688086_comment_15.patch | 594 bytes | francewhoa |
| #13 | storm_issue_688086_comment_13.patch | 601 bytes | francewhoa |
| #11 | storm_issue_688086_comment_11.patch | 360 bytes | francewhoa |
Comments
Comment #1
Magnity commentedPlease could you post this in patch format?
Comment #2
ñull commentedComment #3
Magnity commentedHmmm, I suspect this change of style is simply a matter of preference. Although it could be a better way of formatting the body areas, I think it makes some storm nodes look odd - such as knowledge base.
Therefore, in favour in principle of reformatting the fields display, but it needs to consider all storm content types.
Patch will not apply now also as I've just committed changes to that file.
Comment #4
francewhoa+1 for porting com2 patch.
Much easier to read. When testing 'Knowledge' or 'Task' description fields make sure you have a few paragraphs in there. The difference is obvious with paragraphs. Much easier to read. Find below screenshots to clarify.
Comment #6
francewhoaMy screenshots in #4 aren't from com2's patch. I'll try posting a new patch against current dev later.
Comment #7
francewhoaPatch is against 6.x-1.x-dev (2010-Mar-28) at http://drupal.org/node/253484
This patch does two things. First it adds spacing between paragraphs. Making them easier to read. Second it aligns left the 'description' section. For the same reason, making it easier to read. What do you think?
Find below BEFORE and AFTER screenshots to previews.
This patch must be test by someone else before being ported. Any volunteer?
BEFORE patch
width="100%">
rel="nofollow">
AFTER patch
width="100%">
rel="nofollow">
Comment #9
juliangb commentedTwo notes about the patch before I can review:
- The testbot needs unix style line endings to apply it.
- It is almost impossible to see the change that is being made because the patch seems to remove the entire contents of the file and add it back in.
Comment #10
francewhoaThanks for your comment juliangb. I built the patch using Linux command line (Ubuntu Server 8.04 LTS). But before that I did edit the file using Windows XP. Maybe Windows XP changed the file line endings without asking. Another one for the Windows mystery pile (joke ;)
I'll submit a new patch later. This time using Linux only for the whole process.
Comment #11
francewhoaPatch is against 6.x-1.x-dev (2010-Apr-04) at http://drupal.org/node/253484
This patch must be test by someone else before being ported. Any volunteer?
My patch in #7 was a user error. I was using BlueFish editor version 1.0.7 for Windows. Upgrading to version 2.0.0 fixed it. The new version doesn't change the file's encoding and line ending.
Comment #13
francewhoaTake 3. This new patch is against current Drupal 6 dev version from CVS.
I'm learning Eclipse and CVS. Thanks for your patience ;)
Comment #15
francewhoaTake 4. I double checked and my Eclipse is configure properly for Drupal. I followed the instructions at http://drupal.org/node/75242#PDT
Comment #17
francewhoaTake 5. Maybe I checked out the wrong CSV version. This new patch is against HEAD not branch 6--1.
Comment #19
francewhoaWell I tried. Help would be welcome. Anybody using Eclipse 3.5 on Windows?
Comment #20
francewhoaTake 6. Patch was created with Eclipse 3.5.2 on Linux (Ubuntu) only. Against HEAD.
Comment #21
francewhoaThat's more like it :) I'm so proud of my first patch with the new Eclipse I'll frame comment #20, laminate it, then make t-shirts (joke ;)
This patch must be test by someone else before being ported. Any volunteer?
Note to myself: I did exactly the same thing I was doing on Windows. So the most likely causes of the issue is Windows XP modifying the file encoding without asking, or Windows anti-virus scanning the patch then modifying it, or a glitch in Eclipse Windows version.
Comment #22
juliangb commented#20: storm_issue_688086_comment_20.patch queued for re-testing.
Making sure that this still applies.
Comment #23
juliangb commentedCommitted, thanks.
Comment #24
francewhoaThanks juliangb :)