Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.When you look at search settings, its easy to spot the odd one in the crowd. Active search modules has no fieldset around it, where it should have. It seems this was forgotten in the initial commit.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | searchadminfieldset.patch | 1.06 KB | casey |
| #6 | searchadminfieldset.patch | 845 bytes | casey |
| #1 | activesearchmodules_before.png | 5.33 KB | Bojhan |
| #1 | activesearchmodules_after.png | 8.27 KB | Bojhan |
| #1 | add.fieldsetactivesearch.patch | 1.7 KB | Bojhan |
Comments
Comment #1
Bojhan CreditAttribution: Bojhan commentedAfter
Comment #6
casey CreditAttribution: casey commentedReroll + small change:
$form['search_active_modules']['options'] isn't going to work with variable_get('search_active_modules')
should be:
$form['search_active_modules']['search_active_modules']
Comment #7
casey CreditAttribution: casey commentedComment #8
Bojhan CreditAttribution: Bojhan commentedWorks
Comment #9
webchickIt's a bit unorthodox to repeat ourselves repeat ourselves that way. ;) I worry it's going to create confusion for developers trying to read this and suss out what the variable name is.
Can we make the first index just 'active' instead of the full name of the variable?
Comment #10
casey CreditAttribution: casey commentedComment #11
Bojhan CreditAttribution: Bojhan commentedBack to RTBC
Comment #12
webchickCommitted to HEAD. Thanks!