When we get around to a 7.x release, #25801: taxonomy_select_nodes() hard codes limit may allow us to remove some code that we had borrowed from taxonomy a long time ago.

Comments

mgifford’s picture

any idea when that will be?

mariusz.slonina’s picture

.

joostvdl’s picture

Any timeframe for this nice module?

damiandab’s picture

subscribing

JGO’s picture

Subscribing

carvalhar’s picture

so?

mgifford’s picture

Anyone tried to put this through Coder for an "automated" upgrade? It doesn't catch everything but it is a very useful place to start with a patch.

vali hutchison’s picture

Subscribing

ccshannon’s picture

subscribe

murz’s picture

subscribe

Anonymous’s picture

+1 for this very useful module

bib_boy’s picture

any sign off this? moving to D7 these days and love to take this with me! Always happy to test.

valthebald’s picture

I'm afraid coder module won't help in that specific case.
D7 taxonomy significantly differs from D6 in that it does not store node/term relation in one table.
Instead, term reference is a regular FieldAPI field.
I'm currently digging in the code, will try to publish something working in a couple of days

mgifford’s picture

Thanks for the update @valthebald - looking forward to seeing the patch when you have time to produce it.

valthebald’s picture

StatusFileSize
new12.54 KB

It's probably not worth to make a patch against master (there are too many changes), so I attach the whole contents of the module folder.
This is, of course, only proof of concept, yet ordering works.
Would be nice if someone else (or maintainer) will try this.
Enjoy on your own risk :)

valthebald’s picture

Status: Active » Needs review
Adlatus’s picture

Assigned: Unassigned » Adlatus
Category: support » bug

node/add/article

PDOException: SQLSTATE[HY093]: Invalid parameter number: parameter was not defined: SELECT v.vid AS vid FROM {taxonomy_vocabulary_node_type} vnt JOIN {taxonomy_vocabulary} v ON vnt.vid = v.vid WHERE vnt.type = :vnt.type AND v.module = :v.module; Array ( [:vnt.type] => article [:v.module] => nodeorder ) w nodeorder_can_be_ordered() (linia 568 z /sites/all/modules/nodeorder/nodeorder.module).

valthebald’s picture

#17: it's pretty hard to proceed without involving module maintainers.
Any news about their plans regarding this module?

marcp’s picture

Status: Needs review » Needs work

@valthebald - Thank you for taking this on. I just cut a 7.x-1.x branch off master. Would you please create a patch off 7.x-1.x so folks here can try out the code?

valthebald’s picture

StatusFileSize
new64.07 KB

Sure, here it is.
Here what I've done:

  1. Run coder module on the source code to make most obvious API change
  2. Changed table names to D7 equivalents (maybe not all)
  3. Made other corrections that stopped module from working

For sure, admin part does not work and there are many glitches.
Right now, module assumes that all vocabularies can be ordered

valthebald’s picture

Version: master » 7.x-1.x-dev
valthebald’s picture

Status: Needs work » Needs review
StatusFileSize
new64.19 KB

Attached patch allows full node cycle (create/update/reorder/delete)

pgrond’s picture

I tried the 7.x-1.x branch with the patch from #22, but I get the following error when I try to make a vocabulary sortable:
PDOException: SQLSTATE[42S02]: Base table or view not found

It's complaining about the taxonomy_term_node table which does not exist.

p.selfin’s picture

sub

bib_boy’s picture

sub

bib_boy’s picture

just wondering if there was an update on a possible 7xdev deployment of nodeorder soon?

valthebald’s picture

I'm using patch from #22 on several sites now - it throws sometimes messages and not all admin screens are working, but basically it works.
Patches of that size are hard to maintain, so I really-really-really stuck without any input from maintainer :(

mgifford’s picture

Have you tried to contact him/her/them? Send them an email or note on twitter?

If they needed help maintaining it, would you be able to provide assistance?

valthebald’s picture

Yep, see comment #19 from the module maintainer.
I'm all in to help :)

marcp’s picture

Thanks very much for taking on co-maintainership of Nodeorder, @valthebald -- I really appreciate it!

valthebald’s picture

Assigned: Adlatus » valthebald
Status: Needs review » Needs work

Patch from #22 was committed to 7.x-1.x, and I created alpha1 release.
From that point, I want to make a list of things to accomplish before release 7.x-1.0.
Should this be done here, or it's better to create another thread?

valthebald’s picture

Multiple bugs were fixed, and there is alpha2 release now.
Please report if you experience problems

mgifford’s picture

Status: Needs work » Closed (fixed)

That's great. I'm just going to close this issue then.

DanielWashbrook’s picture

Version: 7.x-1.x-dev » 7.x-1.0-alpha2

I just tried Alpha2 and I get the same error as #17

PDOException: SQLSTATE[HY093]: Invalid parameter number: parameter was not defined: SELECT v.vid AS vid FROM {taxonomy_vocabulary_node_type} vnt JOIN {taxonomy_vocabulary} v ON vnt.vid = v.vid WHERE vnt.type = :vnt.type AND v.module = :v.module; Array ( [:vnt.type] => products [:v.module] => nodeorder ) in nodeorder_can_be_ordered() (line 571 of /sites/all/modules/nodeorder/nodeorder.module)

Somehow the module has to tell if the node type has a taxonomy field pointing to an orderable taxonomy?

Daniel

syakely’s picture

mgifford’s picture

Why?