Comment Signature attach WYSIWYG [#613096]

So I know this has been talked about and passed around to better formats #366015: Add module to fix missing input formats in Drupal core. And looking at better_formats, it looks like it would totally work as it adds a 'format' element to it.

but I don't want to add yet another module to achieve this. Stands to reason that WYSIWYG should support Drupal core, which would mean it should support all the forms that call filter_form().

Those are:
block_box_form -> adds a 'format' element
comment_form -> adds a 'format' element
node_body_field -> adds a 'format' element
user_edit_form -> adds a 'signature_format' element

This little patch does it for user_edit_form the only one not working in the current code.

Comment	File	Size	Author
	wysiwyg_signature.patch	771 bytes	Scott Reynolds

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

TwoD

Swedish

Sweden

CreditAttribution: TwoD commented 23 October 2009 at 22:33

+++ wysiwyg.module
@@ -122,7 +122,7 @@ function wysiwyg_process_form(&$form) {
-      if ($item === 'format' && $index > 0) {
+      if (($item === 'format' || $item === 'signature_format') && $index > 0) {

There has been discussions on changing it to look for items named 'format' or ending with '_format'. That would also cover Views' header and footer textareas. I think that would be a better thing to do if we decide to do something about this. I want sun's opinion on this as well.

This review is powered by Dreditor.

Comment #2

Scott Reynolds CreditAttribution: Scott Reynolds commented 23 October 2009 at 23:51

My argument was only Drupal core. It was meant to keep this patch in scope. I don't want to rehash all those other arguments, not worth my time. Again, you want more advance features use better formats.

Makes total sense to me.

Comment #3

sun

German

Karlsruhe

CreditAttribution: sun commented 7 February 2010 at 15:16

Status:

Needs review

» Fixed

Since this is broken code in core, and broken code in core cannot be changed easily, we need to make Wysiwyg support the broken code, unfortunately.

This applies only to Drupal 6.x though. 5.x does not use a separate format for user signatures (yet? it's an SA), and handling of text formats is different in D7.

Thanks for reporting, reviewing, and testing! Committed to all 6.x branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.