Event All Day needs a code cleanup and needs PHP-based detection to avoid flicker, as described in the README.txt file:
When showing the edit form, javascript decides to hide the fields if both are at midnight. This could be done in php which would save a minor flicker after page renders.

I'll be writing a patch to accomplish this.

CommentFileSizeAuthor
#4 event_all_day_0.patch5.55 KBpraseodym
#3 event_all_day.install595 bytespraseodym

Comments

praseodym’s picture

praseodym commented

I finished all code and went testing, but things didn't work out: it turned out that the event_all_day_form_alter() function was called after event.module's nodeapi, so we can't modify the form elements event.module adds. I'll be solving this with a #pre_render function (should work).

praseodym’s picture

praseodym commented

Never mind that, making the module heavier than event.module fixes it.

praseodym’s picture

praseodym commented
StatusFileSize
new event_all_day.install595 bytes

Install file for weight.

praseodym’s picture

praseodym commented
Status: Active » Needs review
StatusFileSize
new event_all_day_0.patch5.55 KB

Patch against cvs.

decafdennis’s picture

decafdennis commented

The install file looks good and is indeed necessary.

I'll look into the patch; first impression is that there is some 'hairy' code, but I can't say this for sure right now.

To be continued.

killes@www.drop.org’s picture

killes@www.drop.org commented
Component: Event All Day » Code
Status: Needs review » Closed (won't fix)

event all day has been fixed in a adifferent way.