Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.There are a few spots in the new update manager workflow that use "Do Stuff" buttons instead of "Do stuff".
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 605920-10.update_manager_button_fixes.patch | 1.46 KB | dww |
| #8 | 605920-8.update_manager_button_fixes.patch | 1.45 KB | dww |
| #8 | 605920-8.screen_after.png | 30.76 KB | dww |
| #4 | 605920-4.button_before.png | 3.28 KB | dww |
| #4 | 605920-4.button_after.png | 2.55 KB | dww |
Comments
Comment #1
dwwTagging for UX folks...
Comment #2
dwwNote, I just discovered #609772: Impossible to extend the FileTransfer class system in contrib. That's basically unrelated to this patch, but I wanted to point it out for anyone testing this. I mention it here since the process of changing "Process Updates" (which was the wrong button label to be using inside authorize.php, anyway) to "Authorize" also made me want to change a few of the form element ids, etc. You might think that's what broke #609772, but no, that's broken right now in HEAD, regardless of this patch.
Comment #3
Bojhan CreditAttribution: Bojhan commentedCan you provide before/after screens?
Comment #4
dwwI can't believe I just spent 5 minutes providing screenshots for this patch. This is trivial button label fixing. This hardly requires in-depth UI effort. If you want to spend energy on that, please focus on something more relevant like #602490: Fix help text and action links to find the update manager pages or #602496: Clean up the update manager project selector page when updating your site. Thanks.
Comment #5
Noyz CreditAttribution: Noyz commenteddww, for what it's worth, it IS helpful to provide screenshots. People like myself are able to drop in completely out of context, and understand exactly what's going on without reading the entire issue que, or installing patches to figure out how you've improved something.
Comment #7
Bojhan CreditAttribution: Bojhan commented@dww After reviewing the screenshots, I think we should not go down the path of using "Authorize" although it might sound accurate. It is a scary word, it is what you expect when you make 20 bank transfers not when you update your site, it might be a slight shift in perception but its is very critical for the confidence of users in the next step they will encounter after this.
Since this will almost always encounter in a flow, I think it is more fitting to call it "Continue" - which is also conform to the Drupal standard. Where we carefully choose to Continue, even when it might not be the most accurate work -for example in the installer.
Pretty much RTBC, from the rest.
Comment #8
dwwRight, Bojhan and I hashed this out in IRC and I suggested "Continue" there as the alternative. Either way is fine with me. So, here it is with "Continue"...
Note, I tried changing the underlying form elements and JS stuff to match "continue" instead of "process" again, but it all came crashing down. This JS code is quite fragile. :( That's going to have to be cleaned up at #609772: Impossible to extend the FileTransfer class system in contrib, not here. So, this is now a trivial patch.
Based on Bojhan's UI review, and the trivial nature of the current patch, this is now RTBC.
Comment #9
dwwComment #10
dwwFixed a few minor code-style issues in the comments being touched by this patch, instead of including those fixes over at #605344: Docs and code style fixes for update manager since then the patches would conflict.
Comment #11
webchickLooks good. Committed to HEAD.