I ran into this first with a css issue. There are so many css files in a drupal site as there is. No need to display more to the user than they can use.

CommentFileSizeAuthor
bawstats.css_.patch570 bytesmgifford

Comments

egfrith’s picture

egfrith commented

Thanks for this and sorry for the delay in replying.

In principle, the idea of serving as few CSS files as possible sounds good. However, I'm wondering how this would interact with CSS aggregating, if it's enabled. Is it be possible that the CSS comes through in the aggregated file anyway? Is it be possible for the CSS to be aggregated when an someone without "view site statistics" permission is logged in?

mgifford’s picture

mgifford
he/him
Primary language English
commented

Ok, you got me there. Not sure how caching css files is managed for logged in users. I'll let you know if I do find out though.

egfrith’s picture

egfrith commented
Status: Active » Needs work

Great - if it looks like your patch or a modified version of it wouldn't cause problems, I'd be happy to commit it.

egfrith’s picture

egfrith commented

Thanks - if it looks like your patch or a modified version of it wouldn't cause problems, I'd be happy to commit it.

egfrith’s picture

egfrith commented
Assigned: Unassigned » egfrith
Status: Needs work » Fixed

This has now been applied: http://drupalcode.org/project/bawstats.git/commit/d2c4bec
Apologies for the long delay in this happening - I don't know why it took so long.

mgifford’s picture

mgifford
he/him
Primary language English
commented

glad it is in..

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.