Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.If you enter something with multiple lines using wysiwyg + fckeditor and click the source button or the Disable rich-text link it is all displayed as one line. However if I do the same thing using the fckeditor module it will keep the line breaks.
I verified that the fckeditor settings that is being passed is the same between the two. I am using the same version of fckeditor that leaves me to believe it is a wysiwyg issue. Here are the settings being passed to fckeditor with wysiwyg.
"wysiwyg": {
"configs": {
"fckeditor": {
"format2": {
"EditorPath": "/sites/all/libraries/fckeditor/",
"SkinPath": "/sites/all/libraries/fckeditor/editor/skins/default/",
"CustomConfigurationsPath": "/sites/all/modules/wysiwyg/editors/js/fckeditor.config.js",
"Width": "100%",
"Height": 420,
"LinkBrowser": true,
"LinkUpload": false,
"ImageBrowser": true,
"ImageUpload": false,
"FlashBrowser": true,
"FlashUpload": false,
"IncludeLatinEntities": false,
"IncludeGreekEntities": false,
"FontFormats": "p;address;pre;h2;h3;h4;h5;h6;div",
"FormatSource": true,
"FormatOutput": true,
"EnterMode": "p",
"ShiftEnterMode": "br",
"ToolbarSet": "Wysiwyg",
"buttons": [ [ "Source", "SpellCheck", "Cut", "Copy", "Paste", "PasteWord", "Undo", "Redo", "Link", "Unlink", "Anchor", "Replace", "SelectAll", "Image", "Bold", "Italic", "Underline", "StrikeThrough", "JustifyLeft", "JustifyCenter", "JustifyRight", "UnorderedList", "OrderedList", "Superscript", "Subscript", "Outdent", "Indent", "Table", "TableCellProp", "TableInsertRowAfter", "TableInsertColumnAfter", "TableInsertCellAfter", "TableDeleteRows", "TableDeleteColumns", "TableDeleteCells", "TableMergeCells", "TableHorizontalSplitCell" ] ],
"LinkBrowserURL": "/imce?app=fckeditor%7Curl%40txtUrl",
"ImageBrowserURL": "/imce?app=fckeditor%7Curl%40txtUrl%7Cwidth%40txtWidth%7Cheight%40txtHeight",
"FlashBrowserURL": "/imce?app=fckeditor%7Curl%40txtUrl"
}
}
},
"showToggle": 1,
"editorBasePath": "/sites/all/libraries/fckeditor",
"execMode": "",
"disable": "Disable rich-text",
"enable": "Enable rich-text",
"plugins": {
"format2": {
"native": {
"dragresizetable": [ ],
"tablecommands": [ ]
},
"drupal": [ ]
}
}
},
Here are the settings being passed by fckeditor module
oFCK_1.BasePath = '/learning/sites/all/modules/fckeditor/fckeditor/';
oFCK_1.Config['SkinPath'] = oFCK_1.BasePath + "editor/skins/default/";
oFCK_1.Config['CustomConfigurationsPath'] = "/learning/sites/all/modules/fckeditor/fckeditor.config.js?1242078912";
oFCK_1.Width = "100%";
oFCK_1.Height = "420";
oFCK_1.Config['LinkBrowser']= true;
oFCK_1.Config['LinkUpload'] = false;
oFCK_1.Config['ImageBrowser']= true;
oFCK_1.Config['ImageUpload'] = false;
oFCK_1.Config['FlashBrowser'] = true;
oFCK_1.Config['FlashUpload'] = false;
oFCK_1.Config['FontFormats'] = "p;div;pre;address;h1;h2;h3;h4;h5;h6";
oFCK_1.Config['FormatSource'] = true;
oFCK_1.Config['FormatOutput'] = true;
oFCK_1.Config['EnterMode'] = 'p';
oFCK_1.Config['ShiftEnterMode'] = "br";
oFCK_1.Config['EditorAreaCSS'] = "/learning/sites/all/modules/fckeditor/fckeditor.css";
oFCK_1.ToolbarSet = "UCMerced";
oFCK_1.Config['LinkBrowserURL']= '/learning/?q=imce&app=FCKEditor|url@txtUrl';
oFCK_1.Config['ImageBrowserURL']= '/learning/?q=imce&app=FCKEditor|url@txtUrl|width@txtWidth|height@txtHeight';
oFCK_1.Config['FlashBrowserURL']= '/learning/?q=imce&app=FCKEditor|url@txtUrl';
oFCK_1.Config['DefaultLanguage'] = "en";
oFCK_1.Config['AutoDetectLanguage'] = true;
oFCK_1.Config['ToolbarStartExpanded'] = true;
oFCK_1.Config['TextareaID'] = "edit-body";
Any Ideas?
| Comment | File | Size | Author |
|---|---|---|---|
| #25 | fckeditor_wysiwyg_2_2.png | 27.56 KB | generalelektrix |
Comments
Comment #1
TwoDThank you for providing the settings, it makes it a lot easier to try to recreate and verify issues.
Unfortunately, I'm not able to recreate the "all displayed as one line" part. I get formatted output (paragraphs on separate lines, indented lists etc), but the whitespaces in the source (between tags) are removed, I assume it's because of FCKeditor's own formatting removing them but I have not verified this completely.
It looks like you have no "Drupal plugins" such as Teaser Break or Image Assist enabled, which means the output of FCKeditor should not be touched at all by Wysiwyg module.
I do not have FCKeditor.module installed at the moment so I can't run a complete comparison. Maybe they have something in their custom configurations file which changes how it treats whitespaces?
I'll leave this issue open as I do not have a good answer now, nor the time to dig deeper.
Comment #2
redndahead CreditAttribution: redndahead commentedI just tried it on a fresh install with only wysiwyg module enabled and using fckeditor 2.6.3 on FF3.5 and Opera and it still doesn't work. Under cleanup and output I have tried:
* unchecking Remove line breaks
* Checking Apply source formatting
* Checking preformatted
And combinations between those. If you can get it to work on a fresh install with fckeditor please tell me what settings you had selected.
Thanks for looking at it.
Comment #3
redndahead CreditAttribution: redndahead commentedBtw the white space in the source being removed that you mentioned is the issue at hand.
Comment #4
redndahead CreditAttribution: redndahead commentedActually in my fresh install if I write in fckeditor it doesn't preserve space, but if I click source and edit then it does. Using the same settings I still can't get it to work in my production install though. On fresh install Verify html, Convert font tags, and Apply source formatting is checked.
Edit: This only works in Opera and not FF. I tried it on the production site I worked with and whitespace is preserved as long as I use opera.
Comment #5
TwoDAh ok, browser issue then, thanks for finding that. (I used FF as well.)
The editor uses some browser functions to parse/build the markup, which is probably why the whitespaces are treated differently, let's see if we can do something about that.
I'm a bit confused so let me just sum this up to see if I got it right.
Fresh install:
In FF, using Wysiwyg module, whitespaces are not preserved.
In FF, using FCKeditor module, whitespaces are preserved?
In Opera, using either Wysiwyg or FCKeditor module, whitespaces are preserved.
We'll leave the production site for later and focus on isolating the issue first.
Comment #6
redndahead CreditAttribution: redndahead commented@TwoD you got it right. But opera only preserves it while you are editing the code in source view. If you type it straight into the editor and then click source it does not create new lines.
Really thanks for the help.
Comment #7
glass.dimly CreditAttribution: glass.dimly commentedConfirm this issue.
Comment #8
glass.dimly CreditAttribution: glass.dimly commentedMay I just weigh in to respectfully submit that this issue was intolerable for me (unreadable source code is not an option for me), and that I switched from WYSIWYG to the FCKeditor module as a result.
I know that the WYSIWYG module is what will eventually have a shot at core, but in the mean time I had to switch.
Comment #9
TwoD@glass.dimly, I don't blame you for doing so. Readable source is very important to me too.
I'm currently focusing on the CKeditor inplementation, but while reading their code I came across some comments about issues similar to this. I think I can use some of that to find a fix for this later.
Comment #10
redndahead CreditAttribution: redndahead commentedIf ckeditor fixes this issue and you can get ckeditor support to be on par with fckeditor support then that's a fix for me. :)
Comment #11
arnieswap CreditAttribution: arnieswap commentedUsing Wysiwyg API doesn't allow text longer than 4000 words, it is a serious bug for sites into content development. Wysisyg API doesn't show any text longer than 4000 words, it MUST be unlimited. I started using this API but then had to uninstall it. It is broken.
Please fix it.
Comment #12
TwoDThe issue arnieswap mentioned is #602116: Long text is not rendered when viewing a node, but I have not been able to reproduce it.
CKEditor support is now almost on the same level as FCKeditor, but we really need to fix the issues about advanced settings and sorting of toolbar buttons or Wysiwyg module won't be able to show it at its best. ;)
Regarding this issue, I have not yet had time to dig into it.
Comment #13
TwoDFCKeditor explicitly removes newlines between tags and there is no setting to change this behavior.
For a reference, see fckeditor/editor/_source/internals/fckxhtml.js line 275.
Anything between tags is treated as text nodes, and fckeditor's data processor first replaces all newlines with spaces when serializing the nodes in the editing area to an XHTML string, and then removes all the spaces.
If I enter
in source mode (or with the editor turned off), it is correctly parsed into the editing area DOM as two paragraph elements with a text element between them (containing the
\n's).Once the (X)HTML is retrieved via
GetXHTML()it is serialized intoor
depending on the FormatSource setting.
(This was tested with FF 3.5 and IE 8)
I double checked this with FCKeditor.module's own demo site and the same thing happens there.
Could you provide a piece of code which gets incorrectly formatted when using Wysiwyg module, but not when using FCKeditor module?
Paste the original code here. Paste it in Source mode in FCKeditor. Change to WYSIWYG mode and back to Source mode. Then paste the reformatted code here. Same for both modules.
Comment #14
redndahead CreditAttribution: redndahead commentedHere is a simple example. I just did a fresh install of each on two different test sites.
FF 3.5 Ubuntu
1) Type
2) click view source
Fckeditor
wysiwyg
Comment #15
TwoDI get
with Wysiwyg 6.x-2.x-dev as of today and FCKeditor 2.6.4 and FCKeditor 2.6.5. (Usually it inserts a first too, but I removed that before typing.) FF 3.5 on WinXP and Ubuntu 9.04 and IE 8 on Win XP.
I've checked Verify HTML, Convert
<font>tags to styles, Remove linebreaks and Apply source formatting.I don't know what to do about this... Do you have the testsites online? Would be a lot easier for me to debug and figure out what's different between our setups.
Comment #16
redndahead CreditAttribution: redndahead commentedHah moving to 2.x dev fixed the issue.
So a patch somewhere between there took care of it.
Sweet!!
Comment #17
TwoDGreat! Have fun with the newlines! ;)
Comment #19
generalelektrix CreditAttribution: generalelektrix commentedI just installed Wysiwyg 2.2 as recommended and I have FCKEditor 2.6.5: The problem is back. Whenever I look at my source code, all the linefeeds are gone and the whole code is on a single line. I disabled all the filters. With Wysiwyg 2.1 I didnt have that problem, it is back when I installed 2.2. Could you please look into that?
Comment #20
TwoDThere have been no changes to fckeditor.inc, fckeditor-2.6.js or fckeditor-config.js between 2.1 and 2.2 that could have affected this behavior. Can you please check the conversation above and compare your editor settings? Especially the "Apply source formatting" checkbox.
Input filters won't affect this behavior as they only change the rendered output.
Did you upgrade directly from 2.1 to 2.2 or uninstalled (or never had installed) 2.1 before installing 2.2?
Comment #21
generalelektrix CreditAttribution: generalelektrix commentedI can only say that:
I was on 2.1 and it wasn't messing with the source code line breaks. When I installed 2.2 all my line breaks were gone.
It's always an annoying thing when installing an update breaks something that worked witht the previous version. I wasted 2 days of work to try to solve this problem (I already read the whole discussion and tried a lot of things). Sorry to be so bitter, but I don't want to spend more time on this. Wysiwyg editors should not mess with source code line breaks and indentation, that's all I have to say.
Comment #22
generalelektrix CreditAttribution: generalelektrix commentedAnswering your question about the way I upgraded from 2.1 to 2.2: I simply followed the usual process of Drupal modules upgrading:
1- Put in maintenance mode.
2- Take backups of files and database.
3- Disable module.
4- Install new version.
5- Run update.php.
6- Re-enable module.
7- Put back site in normal mode.
I installed updates for other modules (there were a lot of updates available coming back from the holidays) at the same time as well as an update for Drupal core from 6.19 to 6.20.
Comment #23
TwoDI'm assuming step 6.5 is running update.php again, or Wysiwyg has no chance to run its own updates. ;)
Wysiwyg 2.2's update code adds a new table wysiwyg_users, without it you'll get serverside errors, but it would not affect the editor's ability to format the source.
If you go back to 2.1, does it work again?
On a side-note: To generate valid output, editors usually have no choice but to overwrite the old contents and generate all new markup, if not only to avoid browser bugs.
The editor might also have been configured to generate markup with formatting that doesn't match that of the original content, making preserving indents or newlines impossible.
Oh btw, so we're on the same page; I'm also assuming that "With 2.2 all my linebreaks were gone" means that the editor no longer adds linebreaks after things like p tags?
And that this happens when content is actually opened in the editor, not also on content that never was edited after the update, as would appear to happen if the Linebreak converter filter was once enabled and is now disabled. (Not trying to dumb things down here, just have to ask to be sure I know exactly what you mean.)
Oh btw, the Teaser Break plugin is known to distort the source at least in IE, if you have it enabled please try disabling it and see if it makes a difference.
Comment #24
generalelektrix CreditAttribution: generalelektrix commentedYes, I ran update.php after enabling the modules, I just accidentally inverted the sequence while typing it.
I didn't try going back to 2.1 yet. Instead I Installed CKEditor 3.5 as a module and I managed to configure it to avoid losing my linebreaks and indentation. It's not perfect, it still messes up my code a bit, but it's another matter which I already brought to the attention of the folks maintaining CKEditor.
FWIW, here's the code as it looked like before (with Wysiwyg 2.1):
And after (2.2):
It's unreadable and it becomes real hard to copy and paste a <li> line.
I didn't change anything to the configuration when that happened. When I installed Wysiwyg it was at version 2.1 and I left all the default config. Never touched it. Wysiwyg was used only for the Full HTML format. BTW, the contents that use the Filtered HTML format were not associated with a Wysiwyg editor and were left untouched. All the linebreaks are still there. I need to specify that to make it clear that the problem is not related to Drupal or another module.
No, we're not on the same page. What the editor did is REMOVE all my linebreaks. And I need them.
I didn't put a Teaser break plugin. My problem is not related to that. My problem is exactly the title of this bug report: Viewing source removes new lines with fckeditor.
Thanks for your help.
Comment #25
generalelektrix CreditAttribution: generalelektrix commentedHo, BTW, it might also be a very important piece of information I forgot to give you: when I installed 2.2, I also lost all the toolbars in FCKEditor 2.6.5. Please see attached image. I had to go in the configuration and check all the buttons to re-enable them and be able to see that the source code was screwed up. It's taken from Firefox 3.6.13.
Comment #26
joelcollinsdc CreditAttribution: joelcollinsdc commentedThis is still happening in the 7.x-2.x branch. It is an extremely annoying issue for us.
It looks like when "Apply Source Formatting" is checked, the source is logically formatted. Only when "Apply Source Formatting" is left unchecked does the source formatting get lost. Sorry I may have misunderstood...is this the intended behavior? Is there no way to get ckeditor/wysiwyg to leave my source formatting intact?
Comment #27
TwoD@generalelektrix:
Hmm, let me try asking that another way. As I said above, the editor always removes all source code formatting when loading the contents and reformats the source while generating markup based on the current DOM tree in the editing area.
Is source formatting "removed" from every single node, even those not yet edited after upgrading? If so, Wysiwyg/CKEditor is not the cause as it never touches content not run through the editor. If only on the edited nodes (as in "linebreak removal happens during editing"), then it's because source code formatting is not enabled.
Re #25:
The empty toolbar happens because we've switched from falling back to the editor's own default layout when no buttons have been enabled on /admin/settings/wysiwyg/profile/#/edit. This behavior is intended as no checkboxes are enabled by default, thus no buttons should be visible. This is an entierly different issue discuessed elsewhere in the queue.
@joelcollinsdc:
No. CKEditor always removes all source code formatting when parsing the original contents and Wysiwyg module itself does not modify them, though it can pass them to third party plugins that may do so. By enabling "Apply Source Formatting" you're activating a set of data processing rules telling CKEditor where it should insert linebreaks and indents when generating the source code based on the current contents in the editing area.
Comment #28
generalelektrix CreditAttribution: generalelektrix commentedThe linebreaks were lost only on the edited nodes.
About #25: This is quite annoying, but I will try to find the other thread and see if I have something to post there.
After reading your answer to joelcollinsdc, I enabled "Apply Source Formatting" along with "Preformatted" and it solved the problem. The editor finally keeps my source code formatted as I want it.
Comment #29
TwoDOk, then the cause was indeed that the editor was not being instructed to apply formatting, which isn't really a bug. :)
Comment #30
generalelektrix CreditAttribution: generalelektrix commentedNo, indeed, the bug is there: #735624: Enabling one button removes default editor toolbar
Version 2.2 screwed up things for us. We were using the default FCKEditor's toolbar and now I learned, by reading long threads, that by default there's no button enabled. Unfortunatly, this thread has been closed and marked as fixed, but it's not fixed at all. The default toolbar was perfect for us, staff was used to it. Two days after upgrading to 2.2 I got a phone call from staff telling me they had no buttons in the editor. I wasted a lot of time searching for a solution, and when I enabled the buttons, I noticed that the source code of many pages was screwed up.
What happened is that: I install a module with default behavior that fits my needs, if not perfectly, at least it doesn't break anything and gives me the extra functionnality I need. Now I upgrade to a newer version that removes all the benefits from having it installed.
Intuitive approach to resolve the problem:
All this time I wasted in this process, I didn't use it to work on the sites I'm building. I really don't need this kind of trouble.
Also, it gives Drupal a bad reputation when I'm talking about this to other professionals around me. Especially when they are using other CMS's and I'm trying to convince them that Drupal is a very good option. We don't need that. This is an aspect of the problem here that has been overlooked. I hope you will bring back decent default behavior for the next version of this module.
Comment #31
TwoDLike I said before, that's a completely different issue than what was originally reported here.
If you're interested in getting decent behavior, then please help out with #277954: Allow to sort editor buttons. That's where the real problem is.
The default toolbar definitions were not at all suited for use with Drupal, but that has been debated to no end elsewhere and I will not go into it any more here.*
This issue is about newlines, let's keep button management in the issues related to that. We won't get anywhere by talking about it here.
Comment #32
cookiesunshinex CreditAttribution: cookiesunshinex commentedI'm using wysiwyg 6.x-2.3 with ckeditor CKEditor 3.5.0.6260
when I click enter, it only looks like the text is on the next line, so I click enter twice.
When I save the node, the paragraph is doubled.
In editor
source
viewing node
How can I fix this. This is very confusing.
I thought this was html_purifier so I disabled autoparagraph. That didn't help so I disabled and uninstalled the HTML purifier module.
Comment #33
cookiesunshinex CreditAttribution: cookiesunshinex commentedI figured out my issue, I'm using the Rubik admin theme.
Hitting enter only showed one carriage return instead of two and also bulleted lists and numbered lists didn't show.
The fix is to change Ckeditor from "use theme css" to "CKeditor default" in admin/settings/wysiwyg -> Edit Profile -> CSS -> Editor CSS
Comment #35
chaloum CreditAttribution: chaloum commentedI have the same issue tried the above solutions but still the whitespace is being striped out of the source view