Use theme_username() for print_mail_form defaults [#572848]

Use theme_username() to allow theme overrides and modules like RealName to influence username defaults in submission form.

Comment	File	Size	Author
#4	print_mail_username.patch	663 bytes	aether
#4
#2	print_mail_username.patch	662 bytes	aether
#2
	print_mail_username.patch	700 bytes	aether

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jcnventura CreditAttribution: jcnventura commented 9 September 2009 at 19:06

Status:

Needs review

» Needs work

Why are you calling the theme function twice?

File	Size
print_mail_username.patch	662 bytes

Comment #3

jcnventura CreditAttribution: jcnventura commented 10 September 2009 at 00:10

Status:

Needs review

» Needs work

The default implementation of theme_username() doesn't accept the plain argument and it returns the HTML pointing to the user page. Since the instances where this string is used require simple text, this patch is unacceptable.

Comment #4

aether CreditAttribution: aether commented 10 September 2009 at 04:02

Status:

Needs work

» Needs review

File	Size
print_mail_username.patch	663 bytes

Ah, right you are. My implementation was specifically related to the RealName module which provides this argument via override. Would strip_tags offer an acceptable workaround as it is used in this patch or is it bad practice to wrap a theme function like this?

Not sure if the check_plain is needed here and will remove it if it is unnecessary in your opinion and the patch is otherwise acceptable.