Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Just upgraded from Beta1 to Beta2 and clicking on thumbnails now goes directly to the nodes instead of activating the Lightbox viewer as it always has.
Comment | File | Size | Author |
---|---|---|---|
#33 | 569526.patch | 597 bytes | 2noame |
Comments
Comment #1
Jerome F CreditAttribution: Jerome F commentedI have encountered the same problem. Looking forward to a fix too. (Though I appreciate the progress in the gallery views a lot !)
Comment #2
fischerj CreditAttribution: fischerj commentedSame problem for me. Subscribing.
Comment #3
swbaker CreditAttribution: swbaker commentedSame problem, also subscribing.
Thanks for the progress and I'm sure a fix is right around the corner. The shift to using Views is a bit jarring for me (I'm a Views-newbie) but I'll get the hang of it.
This might be a separate issue, but how do we get the gallery descriptions to display again? When viewing the /image page in Drupal 6, it used to show the paragraph descriptions that we put for each gallery. Now it only says how many images are in the gallery and when it was last updated. Is this is a Views thing that I need to figure out? Just curious, because we really liked it when it showed the information about the gallery. Thanks!
Comment #4
fischerj CreditAttribution: fischerj commentedThis IS a separate issue, but I can help with that:
I am not quite sure, whether i named the fields / buttons correctly. On my page it is all translated to German. Hope this helps.
Comment #5
Micha1111 CreditAttribution: Micha1111 commentedThere is the same problem with Thickbox
Comment #6
bryrock CreditAttribution: bryrock commented+1 Me too. Subscribing.
Comment #7
swbaker CreditAttribution: swbaker commentedHi folks, sorry for the sidebar conversation but I wanted to thank fischerj (post #4, above) -- I greatly appreciate your help and the steps you describe worked like a charm. Thanks so much!
Now, about that Lightbox2 ... ;-)
Comment #8
alanburke CreditAttribution: alanburke commentedHi all,
This is probably due to the markup changing as the gallery is now generated by views.
I'll have a look when I get a chance.
Comment #9
deshilachado CreditAttribution: deshilachado commentedsubscribing
Comment #10
digidoo CreditAttribution: digidoo commentedsame problem here. subscribing...
Links with rel="lightbox" added manually to a node are still working, though.
The automatic handling settings stopped working. There's no rel="lightbox" added to the random image block and to the galleries for the slideshow.
Comment #11
alanburke CreditAttribution: alanburke commentedDuplicate of #565774: Thickbox printing curious <img>-tag instead of title of image
as far as I can tell.
Comment #12
deshilachado CreditAttribution: deshilachado commentedalpha5, alpha6 and beta1 worked for me using lightbox2,
so i'm not sure if this really is a duplicate,
but i will try your patch from #565774 as soon as possible
Comment #13
2noame CreditAttribution: 2noame commentedAgreed, beta2 is the first patch to break automatic image handling for Lightbox2.
Comment #14
turbanov CreditAttribution: turbanov commentedhttp://drupal.org/node/565774#comment-2015540 doesn't work for Lightbox2 so this is probably not a duplicate.
Comment #15
alanburke CreditAttribution: alanburke commentedIt was the patch at
http://drupal.org/node/565774#comment-2008866
that should have fixed it.
Have you customised your views?
The javascript in Lightbox2 expects certain markup, so if you have varied from that, it won't work.
Any public version where I could take a look?
Comment #16
turbanov CreditAttribution: turbanov commentedNot sure we're all talking about the same issue here.
My problem is not related to any gallery views really, the whole Lightbox functionality is broken.
I have beta2 of the Image module installed, 1.0 of the Upload Image module installed (http://drupal.org/project/upload_image) as I need the image nodes automatically created from attached images and then finally, the 1.9 of the Lightbox2 module (http://drupal.org/project/lightbox2). Straight out-of-the-box, no customization.
Before installing beta2, the image thumbnails (= image attachments) in my nodes opened up in a Lightbox. This seems broken now. Tried it with the Thickbox module too, to no avail.
edit: http://www.soinilkv.fi/kohteet/testi
Comment #17
joachim CreditAttribution: joachim commented> image thumbnails (= image attachments
Are they actually added to the original node as image_attach attachments? Reading that project page doesn't suggest this, rather a custom approach. This would make the problem to do with upload_image module, not this.
Comment #18
bryrock CreditAttribution: bryrock commentedIf I may, here's a real world, production example of what I think turbanov may be referring to...
http://www.johnnyguitars.com/content/brands/fender-squire
This site displays guitars and other music gear. Gear images are uploaded to the site using Image. They are available in galleries, but that isn't the primary purpose for adding them. Each product item has one of these images attached, via image_attach. (any additional images added to one product are added with image_assist, but most items only use one image)
When viewing a list of the products the thumbnails behave as links to the product item's node. When viewing the node, the image is shown in a preview size, and clicking on that will invoke Lightbox for a nice big view of a guitar or whatever the item is.
I tried beta2 on this site over the weekend, but it broke the ability to view these product images in Lightbox. Instead, clicking the images would simply take you away from the product item node and to the image node. We'd like to show that original sized view without leaving the product it is selling.
So I backed out of beta2 and restored the db from backups and went back to using alpha 5, because, for us, it works as desired.
Comment #19
2noame CreditAttribution: 2noame commentedMy own example is that my images are all added via image fupload or import. Until beta2, any thumbnail when clicked would bring up the lightbox viewer and display the preview image. People could then choose to download the full-size image or go to the image node itself to leave comments. This is exactly the functionality I require and if we can't fix it, I'll need to do the same as the previous commenter and restore from backups to beta1, which I really don't want to have to do.
Also, I'll mention that in views, in order to get a thumbnail to bring up the lightbox, you originally had to set it up so that it "links to its node". If you didn't check that box, clicking the thumbnail would do nothing at all because it would only be a thumbnail displaying and nothing else. Now that same setup, does exactly what it says it does, links to the node, completely bypassing the lightbox automatic image handling. Is it possible that we now have to manually add something to views to get this to work correctly? I've tried multiple things, but can't figure out a solution. Is there a way to make views add rel="lightbox" to the links? Is there a custom css class lightbox can be setup with to activate the viewer instead the of the usual auto-handling that no longer works?
Are you going to force Lightbox2 to change the way it works in order to work with image module in future patches? I thought this was just a bug, but it seems to be causing enough confusion that it's working as intended?
Comment #20
dirksonii CreditAttribution: dirksonii commentedSubscribing. Plz unbreak.
Comment #21
_paul_meta CreditAttribution: _paul_meta commented+1 - my experience of the upgrade is exactly the same as byrock.
no lightbox markup is being emitted in to the gallery html so an image gallery image links straight to the image node page.
Comment #22
Garnerin CreditAttribution: Garnerin commentedSame problem here. Subscribing.
Alanburke, answering #15: I have slightly customized the view in order to have 20 images per page instead of 12.
You could have a look at sg-kaarst-volleyball.de if you speak some german words ;-) Otherwise: Look at the top-right menu, the german translation for "image galleries" is "Bildergalerien". If you need more info or admin login or even access to the webserver, then let me know.
Comment #23
turbanov CreditAttribution: turbanov commentedGiven that I'm not exactly sure what you're referring to here and don't really have the time to get to the bottom of it, you maybe correct, but the fact of the matter is that it worked before and doesn't now and thus, this beta2 update is what caused it. That's all.
Anyways, thanks Alan (and everybody else) for your efforts, they are very much appreciated.
Comment #24
swbaker CreditAttribution: swbaker commentedHello again,
Our site is another that uses image and also Lightbox2, and this functionality worked great through the alphas and beta1, but broke with beta2.
We did not use image_attach but rather simply created image node content, associated the image nodes with a particular gallery, and let Lightbox2 work its magic. As stated in previous comments, when we click on a thumbnail, the system now displays the image node rather than kicking in the Lightbox2 effect.
Link to our list of galleries -- http://photos.berkleydems.org
Link to a particular gallery -- http://pubcrawl.berkleydems.org
The system works correctly on the list of galleries; we click on a thumbnail to display the corresponding gallery itself, etc. Lightbox2 didn't jump in for these pics (via a setting in the Lightbox2 configuration as I recall).
However, once viewing a particular gallery, a click on a thumbnail should invoke Lightbox2 rather than bring up the image node. Note that clicking on the caption text under a photo also displays the image node, but it did this before beta2 and it lets folks leave a comment about a particular photo, etc.
(Perhaps another unrelated issue, but the gallery view alignment is now off with the thumbnails in each gallery. It's centering them and the consequence is that items appear staggered because of the length of the caption beneath the photo. Is there a way to top align each row, instead of center align each row?)
Thanks again, and please let me know if there's anything we can do to help test anything, etc.
Comment #25
joachim CreditAttribution: joachim commentedIf you're not using image attach: please see #565774: Thickbox printing curious <img>-tag instead of title of image and try the patch there.
If you ARE using image attach: the only change from b1 to b2 that could affect you is: #567226: image attach views field produces multiple rows for each attached image.
In this case, the image attach Views field has completely changed due to the multi-attach feature.
It's very likely that *boxes aren't getting the markup they expect any more.
If there's anyone who can have a dig in the markup and tell me what's required to change for it to work, that would be a huge help.
Comment #26
deshilachado CreditAttribution: deshilachado commentedI have image_attach enabled, but i guess this doesn't mean i'm using it, right?
i have an example gallery here: http://bdp-sh-hh.de/category/bildergalerien/bundeslager-09
the only customization is that there are 9 images instead of 12
in comment #15 alanburke linked to comment#1 in issue#565774,
but that patch is already included in image beta2,
or at least i find in line 16 of image-view-image-gallery.tpl.php
<<?php print $options['type']; ?> class="images">
lightbox2 worked with alpha5, alpha6 and beta1 of the image module,
but as i understand it issue #565774 is all about alpha5->alpha6
Comment #27
joachim CreditAttribution: joachim commentedThere is another patch at #565774: Thickbox printing curious <img>-tag instead of title of image, further down. Please test it if you are able.
It would greatly help matters if people explained exactly where they are looking at images and how they are being produced.
Where: gallery? gallery view? node?
How: actual image for the node? image_attach? some other module I've never heard of? view field?
Comment #28
2noame CreditAttribution: 2noame commentedNot only does it make no sense to try the #565774: Thickbox printing curious <img>-tag instead of title of image patch, I've tried it and the patch fails. The -b one. I didn't try the one above it. As we've been saying here, there was a change from beta1 to beta2 that is the cause of this problem because it has worked for all of us in this thread UNTIL beta2. This has nothing to do with alpha5, because it still worked in alpha5. And this is not an image attach or non image attach problem, it is an across the board image module problem introduced in beta2 and beta2 only. We could all revert to beta1 and it would work for us.
Comment #29
2noame CreditAttribution: 2noame commentedYou can setup the various sizes to activate Lightbox outside of the node view. If you are using a views block, that will no longer work. If you are using the built-in galleries, that will no longer work. If it's inside a views block or the native recent images or random images block, it won't work. If it's inside a teaser, that won't work. Any thumbnail or preview created by image in any instance, image attach or no image attach, seems to no longer contain the necessary markup for Lightbox and Thickbox to work. There is something missing here that was lost in beta2 that beta1 and everything else before it had.
Comment #30
joachim CreditAttribution: joachim commentedOkay, I was about to say this was total crack as there's nothing in the changelog that could have done this, but I see from the diff for the only change to the image.module file itself that something did change, which doesn't match up to the commit message.
It looks like code sprint fatigue last Saturday... :(
Will post a patch for testing very shortly. If you feel brave, you can try hacking out those lines yourselves ;)
Comment #31
2noame CreditAttribution: 2noame commentedI see. Yeah it looks like image now thinks there are empty attributes that are being removed? I'd try to hack it myself, but I don't know enough to do that. I'm sorry. I'll have to wait for a patch unless you can tell me more about how I'd go about doing it without one.
You guys were doing a lot in a short amount of time. I'm surprised more stuff like this didn't happen. Don't feel too bad about missing something. You do great work. ;)
Comment #32
lenadoppel CreditAttribution: lenadoppel commentedHi
I have the problem with thickbox,
I don't use image galleries and this is not a views problem (as far as I know)
i use image module to put images inside of the body of a node
after upgrading image from alpha6 to beta2 thickbox inside the node body stopped working
I use image attach or image assist (frankly I am confused which does what but I think they work together) to attach image nodes inside of the body field
Basically I click on the little photo camera symbol in the wysiwyg editor, a pop up window opens, I upload a picture (as a node) and select "thumbnail" and "full node" for the "show as" resp "link to" settings
before the upgrade clicking on an image opened it in thickbox displaying the link to it as http://mysiteurl/sites/default/images/[imagename].jpg) after upgrading clicking on one of the images just opens the node page displaying the link differently as http://mysiteurl/node/[nodeid]
I since then reverted to before the module/db update and now thickbox works again
you can take a look at the working version http://www.cat-x.at/news/opening-relative-realities-mexico-city.html
Comment #33
2noame CreditAttribution: 2noame commentedOk, this is my first ever patch I made myself, so I may have done something wrong, but I removed lines 641-644 from image.module, ran a diff between the two files, and then tested the patch on my own. This patch fixes the problem for me. I just don't know if straight out removing those lines is ok?
But here it is for others to test. Hope it works for you too.
Comment #34
joachim CreditAttribution: joachim commentedNice job! Congratulations on your first patch :D
I've also removed the exact change that commit made, so there's a heap of whitespace too.
It seems I was in the middle of testing a different patch on the same codebase ... :(
Committed to CVS:
#569526 by 2noame: Fixed mistaken commit to image.module from #569258.
A new dev version will be created by the system shortly. Please give it a try :)
Comment #35
deshilachado CreditAttribution: deshilachado commentedok, commenting out lines 641-644 with a // does the trick for me
thanks joachim and 2noame!
Comment #36
deshilachado CreditAttribution: deshilachado commentedsorry, didn't mean to change the status
Comment #37
bryrock CreditAttribution: bryrock commentedOutstanding news! I look for to testing it out on a production environment this weekend, during scheduled maintenance. Thanks.
Comment #38
turbanov CreditAttribution: turbanov commentedYeah I can confirm this does indeed fix it. Changed the status back though as those lines are there probably for a reason.
Thanks anyways to all participants.
Comment #39
luusl CreditAttribution: luusl commentedWorks for me on image galleries too, but inline node images attached with Image Assist still open the node for the image.
Comment #40
joachim CreditAttribution: joachim commentedThose lines were there because I had applied a patch from another issue, then got distracted, then applied alanburke's patch for something completely different, and then committed, as it was a one-liner. DOH!
@#39: you should probably open an issue on image assist for that.
Comment #41
luusl CreditAttribution: luusl commentedAh! Shoot to early. I just had to clear the filter cache with calling http://<page_url>/img_assist/cache/clear. Maybe this helps others too. Thanks for the quick fix!
Comment #42
scubasmurf CreditAttribution: scubasmurf commented+1