When creating a field, the Field UI displays a Field Settings fieldset for field types that have no settings; it then displays "[fieldname] has no field settings" in the fieldset. It seems like we should just not show the fieldset at all, and if there is nothing else on the page, don't show that page in the workflow at all.

See http://img.skitch.com/20090901-q326w6d2d8wfd58rcife1g3jia.jpg.

Comments

aspilicious’s picture

Still an issue?
How can I reproduce?

I read this thing 3 times, and i still don't understand...

bradweikel’s picture

Issue tags: +Usability

Adding usability tag, but I can't find a repro path for this because I can't find a field type without settings. Maybe a non-issue now?

yoroy’s picture

Version: 7.x-dev » 8.x-dev
Status: Active » Postponed (maintainer needs more info)

Original report is very hard to understand (I couldn't).

Everett Zufelt’s picture

Status: Postponed (maintainer needs more info) » Active

When adding a field to a entity using the UI (e.g. content type -> manage fields) you:

1. Add the field and click save
2. Are taken to the settings page for the field
3. Are taken to the settings page for the field instance.

Some fields (likely none in Core) have field instance settings, but no field settings. So, in step 2 you are basically taken to a field settings page w/ no controls other than Save. Can't think of a contrib field where this happens, but I am certain I have seen this (perhaps link.module is where I saw it).

Everett Zufelt’s picture

Title: Field Settings fieldset for fields with no settings » Bypass field settings form for fields that don't implement hook_field_settings_form()

Just confirmed that link.module does not implement hook_field_settings_form(), as it declares no field settings, only field instance settings.

Bypassing the field settings form for fields that don't implement hook_field_settings_form() seems like a good idea, but does provide inconsistent behavior when adding new fields.

JvE’s picture

Category: bug » feature
Status: Active » Needs review
StatusFileSize
new3.91 KB
new1.42 KB

When drupal core is installed with the "minimal" profile the Long text fields also have no settings.

Attached patch makes a few changes to the form:
drupal-field_ui-565262-6.gif

Status: Needs review » Needs work

The last submitted patch, drupal-field_ui-565262-6.patch, failed testing.

JvE’s picture

Status: Needs work » Needs review
StatusFileSize
new1.43 KB

Added extra newline at end of file to see if it applies better that way.

valthebald’s picture

Status: Needs review » Needs work

What's the point showing the form with only option to click 'Save'? Can we just skip this step and proceed to the instance settings form?

swentel’s picture

Status: Needs work » Closed (duplicate)