Follow-up to #251792: Implement a locking framework for long operations, we want to us locks to prevent a theme registry rebuild from being performed by more than one request in parallel

CommentFileSizeAuthor
#35 553610-33.patch1.3 KBaleevas
#32 intrdiff_29_32.txt794 bytesaleevas
#32 553610_32.patch1.55 KBaleevas
#29 553610-22.patch1.56 KBaleevas
#21 interdiff-553610-14-21.txt758 bytesaerozeppelin
#21 553610-21.patch1.52 KBaerozeppelin
#15 drupal-lock_theme_registry_build-553610-14.patch800 bytesjibran
#15 interdiff.txt784 bytesjibran
#12 drupal-lock_theme_registry_build-553610-12.patch790 bytesInternetDevels
#9 drupal-lock_theme_registry_build-553610-9.patch4.7 KBInternetDevels
#7 drupal-lockthemerebuild-553610-7.patch549 bytesInternetDevels
#3 lock-theme-rebuild-553610-2.patch851 bytespwolanin
#1 locking-drupal_theme_rebuild.patch675 bytesdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
locking-drupal_theme_rebuild.patch675 bytes

Here is a first version.

I'm wondering how to test the patch, perhaps someone give me a hint.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Status: Needs review » Needs work

this isn't the part that needs the lock

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
FileSize
lock-theme-rebuild-553610-2.patch851 bytes

roughly it should look like this (untested), but we may want to refactor the theme rebuild code a little more.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

opps - this doens't have a lock_release().

Also, given that there is more-or-less a single dB operation here (calling cache_set), it's probably not that high a priority to lock it.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Version: 7.x-dev » 8.x-dev

Bump/subscribe. This is a very big cache object to set, and it's a global cache, preventing multiple sets we should definitely consider, even if we don't want to lock the actual registry building to one process.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Issue tags: +Needs reroll

Patch is so old needs a reroll.

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
drupal-lockthemerebuild-553610-7.patch549 bytes

Reroll

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

@InternetDevels
We should add this lock to / around the \Drupal\Core\Theme\Registry::build() method.

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Issue tags: -Needs reroll
FileSize
drupal-lock_theme_registry_build-553610-9.patch4.7 KB

Another try

Status: Needs review » Needs work

The last submitted patch, 9: drupal-lock_theme_registry_build-553610-9.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

What about wrapping the call to build() so the patch is way smaller?

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Status: Needs work » Needs review
FileSize
drupal-lock_theme_registry_build-553610-12.patch790 bytes

New try

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

@InternetDevels
This looks much better. Now we just have to inject the lock service instead.

Status: Needs review » Needs work

The last submitted patch, 12: drupal-lock_theme_registry_build-553610-12.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs work » Needs review
FileSize
interdiff.txt784 bytes
drupal-lock_theme_registry_build-553610-14.patch800 bytes

Fixed #13.

Status: Needs review » Needs work

The last submitted patch, 15: drupal-lock_theme_registry_build-553610-14.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Yeah I guess we also have to adapt the unit test here.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr as a volunteer commented
Version: 8.0.x-dev » 8.1.x-dev
Status: Needs work » Postponed
Issue tags: +Needs tests

Tagging to maybe get attention from people to update the tests. I think this could be done in a later 8.x.x release.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented

I don't see why this cannot land in a patch release, ... it fixes a potential bug.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch as a volunteer commented
Version: 8.1.x-dev » 8.0.x-dev
Status: Postponed » Needs work

Yes agreed. Should be able to happen in a patch release.

aerozeppelin’s picture

aerozeppelin CreditAttribution: aerozeppelin commented
Status: Needs work » Needs review
FileSize
553610-21.patch1.52 KB
interdiff-553610-14-21.txt758 bytes

An attempt to fix failing tests from #15.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Version: 8.5.x-dev » 8.6.x-dev
Status: Needs review » Needs work
Issue tags: +Needs reroll

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

aleevas’s picture

aleevas
he/him
Primary language Russian
CreditAttribution: aleevas at Skilld commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
553610-22.patch1.56 KB

The patch from the comment#21 was rerolled successfully

Status: Needs review » Needs work

The last submitted patch, 29: 553610-22.patch, failed testing. View results

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

aleevas’s picture

aleevas
he/him
Primary language Russian
CreditAttribution: aleevas at Skilld commented
Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
553610_32.patch1.55 KB
intrdiff_29_32.txt794 bytes

Added fix for last patch.

Status: Needs review » Needs work

The last submitted patch, 32: 553610_32.patch, failed testing. View results

aleevas’s picture

aleevas
he/him
Primary language Russian
CreditAttribution: aleevas at Skilld commented

Added a new patch with fixes

aleevas’s picture

aleevas
he/him
Primary language Russian
CreditAttribution: aleevas at Skilld commented
FileSize
553610-33.patch1.3 KB

Forgot to add patch to the my last comment
Here it is

aleevas’s picture

aleevas
he/him
Primary language Russian
CreditAttribution: aleevas at Skilld commented
Status: Needs work » Needs review
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch as a volunteer and at Third and Grove commented
Status: Needs review » Needs work 
+++ b/core/lib/Drupal/Core/Theme/Registry.php
@@ -230,6 +230,10 @@ public function get() {
+        return FALSE;

This can't return false - it needs to return the theme registry. So it would need to attempt to get the theme registry from cache after the lock wait, then either wait again or rebuild anyway if it's still not there.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.